Integrate Pull Replication's clean read into cloudserver - #6295
SylvainSenechal wants to merge 1 commit into
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
| "@opentelemetry/instrumentation-mongodb": "~0.69.0", | ||
| "@smithy/node-http-handler": "^3.0.0", | ||
| "arsenal": "git+https://github.com/scality/arsenal#8.5.15", | ||
| "arsenal": "git+https://github.com/scality/arsenal#baa462fc", |
There was a problem hiding this comment.
Arsenal is pinned to a commit hash (baa462fc) instead of a release tag. Per project conventions, git-based deps must be pinned to a tag (e.g. #8.5.16).
| "arsenal": "git+https://github.com/scality/arsenal#baa462fc", | |
| "arsenal": "git+https://github.com/scality/arsenal#8.5.16", |
| }); | ||
|
|
||
| after(async () => { | ||
| await removeAllVersionsAsync({ Bucket: bucket }); |
There was a problem hiding this comment.
removeAllVersions lists versions via the S3 API, which applies clean-read filtering. The non-localized version created at line 84 won't appear in ListObjectVersions and won't be deleted. This will likely cause DeleteBucketCommand to fail with BucketNotEmpty, or leave orphaned metadata.
Consider deleting the non-localized version directly via metadata.deleteObjectMD (or s3.send(new DeleteObjectCommand({ ..., VersionId: nonLocalizedVersionId })) if the server allows version-targeted deletes regardless of clean read) before calling removeAllVersionsAsync.
❌ 6 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ISSUE: CLDSRV-957
WIP