Skip to content

Integrate Pull Replication's clean read into cloudserver - #6295

Draft
SylvainSenechal wants to merge 1 commit into
development/9.5from
improvement/CLDSRV-957/clean-read-config
Draft

SylvainSenechal wants to merge 1 commit into
development/9.5from
improvement/CLDSRV-957/clean-read-config

Conversation

@SylvainSenechal

Copy link
Copy Markdown
Contributor

ISSUE: CLDSRV-957

WIP

@bert-e

bert-e commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/bypass_source_branch_lineage Bypass the cross-branch contamination check
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-957 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.5.0

Please check the Fix Version/s of CLDSRV-957, or the target
branch of this pull request.

Comment thread package.json
"@opentelemetry/instrumentation-mongodb": "~0.69.0",
"@smithy/node-http-handler": "^3.0.0",
"arsenal": "git+https://github.com/scality/arsenal#8.5.15",
"arsenal": "git+https://github.com/scality/arsenal#baa462fc",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arsenal is pinned to a commit hash (baa462fc) instead of a release tag. Per project conventions, git-based deps must be pinned to a tag (e.g. #8.5.16).

Suggested change
"arsenal": "git+https://github.com/scality/arsenal#baa462fc",
"arsenal": "git+https://github.com/scality/arsenal#8.5.16",

});

after(async () => {
await removeAllVersionsAsync({ Bucket: bucket });

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAllVersions lists versions via the S3 API, which applies clean-read filtering. The non-localized version created at line 84 won't appear in ListObjectVersions and won't be deleted. This will likely cause DeleteBucketCommand to fail with BucketNotEmpty, or leave orphaned metadata.

Consider deleting the non-localized version directly via metadata.deleteObjectMD (or s3.send(new DeleteObjectCommand({ ..., VersionId: nonLocalizedVersionId })) if the server allows version-targeted deletes regardless of clean read) before calling removeAllVersionsAsync.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
9949 6 9943 0
View the top 3 failed test(s) by shortest run time
should reject a head on the non-localized version::clean read With default signature should reject a head on the non-localized version
Stack Traces | 0.002s run time
Missing expected rejection.
should reject a head on the non-localized version::clean read With v4 signature should reject a head on the non-localized version
Stack Traces | 0.003s run time
Missing expected rejection.
should omit the non-localized version from the version listing::clean read With v4 signature should omit the non-localized version from the version listing
Stack Traces | 0.004s run time
Expected values to be strictly deep-equal:
+ actual - expected

  [
    'aIE3DL8r8i7l00000000001I4j3QKItW',
+   'aIE3DL8qRvxd00000000001I4j3QKItW'
  ]
should omit the non-localized version from the version listing::clean read With default signature should omit the non-localized version from the version listing
Stack Traces | 0.006s run time
Expected values to be strictly deep-equal:
+ actual - expected

  [
    'aIE3DL8zAMkn00000000001I4j3QKItW',
+   'aIE3DL8zobTh00000000001I4j3QKItW'
  ]
should reject a get on the non-localized version::clean read With default signature should reject a get on the non-localized version
Stack Traces | 0.049s run time
Expected values to be strictly equal:
+ actual - expected

+ 'Error'
- 'NoSuchVersion'
should reject a get on the non-localized version::clean read With v4 signature should reject a get on the non-localized version
Stack Traces | 0.097s run time
Expected values to be strictly equal:
+ actual - expected

+ 'Error'
- 'NoSuchVersion'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants