Skip to content

CLDSRV-884: Backport OpenTelemetry tracing instrumentation - #6294

Open
BourgoisMickael wants to merge 4 commits into
development/9.3from
improvement/CLDSRV-884/otel-instrumentation-9.3
Open

BourgoisMickael wants to merge 4 commits into
development/9.3from
improvement/CLDSRV-884/otel-instrumentation-9.3

Conversation

@BourgoisMickael

@BourgoisMickael BourgoisMickael commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick #6140

S3C 10.1 with cloudserver 9.4 is not ready to be used yet so I backport tracing to be used in S3C 9.5 and 10.0.

Changes from cherry-pick:

  • update yarn.lock
  • keeps functions not async but return the Promise for tests
  • test mock throws error instead of passing as callback's first argument

+ update yarn.lock after cherry-pick

Issue: CLDSRV-884
(cherry picked from commit a6f74d3)
Keep functions not async but return the Promise for tests

Issue: CLDSRV-884
(cherry picked from commit 0f86bf9)
@bert-e

bert-e commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/bypass_source_branch_lineage Bypass the cross-branch contamination check
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-884 contains:

  • 9.4.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.21

  • 9.4.4

  • 9.5.0

Please check the Fix Version/s of CLDSRV-884, or the target
branch of this pull request.

@BourgoisMickael BourgoisMickael changed the title CLDSRV-884): Backport OpenTelemetry tracing instrumentation CLDSRV-884: Backport OpenTelemetry tracing instrumentation Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.26%. Comparing base (7904b09) to head (eb92f64).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/server.js 90.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/api.js 93.75% <100.00%> (+0.11%) ⬆️
lib/server.js 87.37% <90.00%> (-0.49%) ⬇️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.3    #6294      +/-   ##
===================================================
- Coverage            85.32%   85.26%   -0.06%     
===================================================
  Files                  206      206              
  Lines                13435    13440       +5     
===================================================
- Hits                 11463    11460       -3     
- Misses                1972     1980       +8     
Flag Coverage Δ
file-ft-tests 68.35% <80.00%> (-0.02%) ⬇️
file-ft-tests-null-compat 68.86% <80.00%> (-0.05%) ⬇️
kmip-ft-tests 28.37% <72.00%> (+0.01%) ⬆️
mongo-v0-ft-tests 69.57% <80.00%> (-0.05%) ⬇️
mongo-v1-ft-tests 69.55% <80.00%> (-0.07%) ⬇️
multiple-backend 36.83% <72.00%> (+0.01%) ⬆️
s3c-ft-tests-v0 64.01% <84.00%> (-0.04%) ⬇️
s3c-ft-tests-v0-null-compat 64.08% <84.00%> (+0.02%) ⬆️
s3c-ft-tests-v1 63.98% <84.00%> (+<0.01%) ⬆️
sur-tests 36.80% <72.00%> (+0.01%) ⬆️
sur-tests-inflights 37.81% <72.00%> (-0.02%) ⬇️
unit 71.35% <72.00%> (+0.07%) ⬆️
utapi-v2-tests 34.62% <72.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/server.js
next => metadata.setup(next),
next => clientCheck(true, log, next),
], (err, results) => {
series([next => metadata.setup(next), next => clientCheck(true, log, next)], (err, results) => {
Comment thread lib/server.js
next => metadata.setup(next),
next => clientCheck(true, log, next),
], (err, results) => {
series([next => metadata.setup(next), next => clientCheck(true, log, next)], (err, results) => {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants