Conversation
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
delthas
force-pushed
the
bugfix/ZENKO-5356/drctl-boolean-flags
branch
from
September 15, 2026 08:11
968e06f to
f4d55ce
Compare
The file tests a helper from common/utils.ts and is about to cover a second one. Name it after the module rather than after a single function, and rename its case list accordingly. Issue: ZENKO-5356
delthas
force-pushed
the
bugfix/ZENKO-5356/drctl-boolean-flags
branch
2 times, most recently
from
September 15, 2026 08:18
ff449e6 to
9ab37a2
Compare
delthas
marked this pull request as ready for review
September 15, 2026 08:20
francoisferrand
approved these changes
Sep 15, 2026
CTST built every zenko-drctl command line with "--flag value". spf13/pflag gives boolean flags NoOptDefVal = "true", so a bool flag does not consume the next argv token: "--force-rotate-service-credentials false" set the flag to true and left "false" as a positional argument, silently accepted because no drctl leaf command declares an Args validator. Every "Given a DR installed" therefore force-rotated the sink's service credentials, regardless of the install counter. On run 34585935213 the six installs produced six rotations on the sink against one on the source, leaving the CR at service-users-seq 7 while pods still mounted user-creds.v1.5. Issue: ZENKO-5356
delthas
force-pushed
the
bugfix/ZENKO-5356/drctl-boolean-flags
branch
from
September 15, 2026 09:33
9ab37a2 to
303c4e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why do we need it?
CTST built every
zenko-drctlcommand line with--flag value. pflag boolean flags donot consume the next argument, so
--force-rotate-service-credentials falseset the flagto true and left
"false"as a positional argument, silently ignored.Every
Given a DR installedtherefore force-rotated the sink's service credentials,instead of only the install that follows an uninstall. Each rotation rolls the sink's
backbeat pods and can stall D/R replication, which shows up as intermittent PRA failures:
on run 34585935213 the six
installs produced six rotations on the sink against one on the source, and both failing
scenarios were replicated deletes that never landed.
Emit booleans as
--flag=value, and coverparamToCliin the tests forcommon/utils.ts, renamed fromparseGoDuration.test.tsnow that it holds cases for asecond helper.
Which issue does this PR fix?
Fixes ZENKO-5356.