fix bug with mongo search option removing deletion filter when top le… - #2707
Open
SylvainSenechal wants to merge 1 commit into
Open
SylvainSenechal wants to merge 1 commit into
SylvainSenechal wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## improvement/ARSN-617/clean-read-filter #2707 +/- ##
==========================================================================
- Coverage 74.74% 74.73% -0.01%
==========================================================================
Files 227 227
Lines 18631 18633 +2
Branches 3863 3864 +1
==========================================================================
Hits 13925 13925
- Misses 4701 4703 +2
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…vel search contains or Issue: ARSN-641
SylvainSenechal
force-pushed
the
bugfix/ARSN-641
branch
from
September 15, 2026 16:15
bae6839 to
fd8b794
Compare
Contributor
Author
|
Will apply linter after parent pr is merged |
SylvainSenechal
requested review from
a team,
DarkIsDude,
benzekrimaha and
delthas
and removed request for
delthas
September 15, 2026 16:18
SylvainSenechal
marked this pull request as ready for review
September 15, 2026 16:19
benzekrimaha
approved these changes
Sep 16, 2026
benzekrimaha
left a comment
benzekrimaha
left a comment
Contributor
There was a problem hiding this comment.
LGTM code wise , on the ci side prettier is failing along with codecov...
DarkIsDude
approved these changes
Sep 16, 2026
DarkIsDude
left a comment
DarkIsDude
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the spot and the PR 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE: ARSN-641
Found this while reviewing the pr of the target branch #2688 (comment)
Added a functional test to verify the bug
Added the fix and rerun the functional test => its fixed
Side note : I think impact is minimal, I don't believe we use top level $or filters