-
Notifications
You must be signed in to change notification settings - Fork 1
feat(harbor): the agent's first baseline eval is budget-free #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shehabyasser-scale
wants to merge
2
commits into
harbor-2-mode-b-sample-timeout-warning
Choose a base branch
from
harbor-2-free-baseline-eval
base: harbor-2-mode-b-sample-timeout-warning
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
_free_baseline_usedread at line 87 (insidefree_baseline = (... and not self._free_baseline_used)) is separated from the write at line 98 byawait self.engine.evaluate(...). If two concurrentevaluatecoroutines arrive while none have completed yet, both will readFalse, both will setfree_baseline = True, and both will be served as admin calls — violating the explicit "capped at exactly one" design goal.The comment "no await runs between the check above and this write" is true about the
if free_baseline: …assignment site alone, but that is not the relevant check. The check that controls the boolean isnot self._free_baseline_usedin thefree_baselinetuple expression, and that read is separated from the write by a fullawait. In a single-threaded asyncio event loop two coroutines can both be suspended atawait self.engine.evaluate(...)having already recordedfree_baseline = True.Fixing this requires setting the flag before the await (then restoring it on exception), or guarding it with a sentinel that is set synchronously before yielding — the mirror of the reasoning that justified moving the assignment after the await in the previous review.
Prompt To Fix With AI