Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the breadcrumbs route definitions to reference the Saucebase\Breadcrumbs classes instead of Diglactic\Breadcrumbs, aligning the module with the intended breadcrumb library during the Laravel 13 upgrade effort.
Changes:
- Switched breadcrumb imports in
routes/breadcrumbs.phpfromDiglactic\BreadcrumbstoSaucebase\Breadcrumbs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+4
| use Saucebase\Breadcrumbs\Breadcrumbs; | ||
| use Saucebase\Breadcrumbs\Generator as Trail; |
There was a problem hiding this comment.
PR title indicates a Laravel 13 upgrade, but this change only updates breadcrumb import namespaces. Consider updating the PR title/description to reflect the actual scope (breadcrumb package swap), or include the other Laravel 13 upgrade commits in this PR to avoid confusion when reviewing/releasing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates a dependency in the
routes/breadcrumbs.phpfile to use theSaucebase\Breadcrumbspackage instead ofDiglactic\Breadcrumbs. This change ensures that the application is referencing the correct breadcrumb library.Dependency update:
Diglactic\BreadcrumbstoSaucebase\Breadcrumbsinroutes/breadcrumbs.phpto use the new library.