Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new uninstall behavior for the Saucebase module installer, making module directory deletion on
composer removeopt-in rather than the default. It also updates the documentation to clarify configuration options, core behaviors, and frontend framework support. Comprehensive tests are added for the new behavior.Uninstall behavior changes:
composer removenow skips deleting the module directory. To enable deletion, setmodule-delete-on-remove: truein the rootcomposer.jsonextrasection. [1] [2]Documentation and configuration updates:
README.mdand addedCLAUDE.mdto document all configuration keys, default values, and behaviors, including uninstall, update strategies, excluded directories, and frontend framework support. [1] [2] [3] [4] [5] [6]Frontend framework support:
frontend.json, and how unused framework files are handled. [1] [2]These changes improve safety during module removal, clarify configuration for users, and ensure the installer’s behaviors are well-documented and thoroughly tested.