Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved handling of merge conflicts by integrating Git index staging for conflicted files, ensuring that conflicts are properly surfaced in developer tools. It also adds comprehensive tests for this new behavior.
Merge conflict handling improvements:
stageConflictInIndextoInstaller.phpthat stages the three-way merge conflict versions (ours,base,theirs) in Git’s index, so conflicts are recognized bygit statusand editors like VSCode. This method degrades gracefully if Git is unavailable or the path is not in a repository.mergeStashto callstageConflictInIndexwhen a conflict is detected, ensuring the index is updated automatically.Testing enhancements:
callStageConflictInIndexto the test installer class for direct testing of the new method.test_stage_conflict_in_index_registers_git_conflict_stagesthat verifies all three conflict stages are correctly registered in the Git index during a merge conflict.Processimport to the test file.