Skip to content

chore: refine update strategy to exclude 'path' dist types from merge… #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roble merged 1 commit into from
Jun 7, 2026
Merged

chore: refine update strategy to exclude 'path' dist types from merge… #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,14 +567,16 @@ public function update(InstalledRepositoryInterface $repo, PackageInterface $ini
$stashPath = null;
$basePath = null;

if ($this->getUpdateStrategy() === self::UPDATE_STRATEGY_MERGE) {
if ($this->getUpdateStrategy() === self::UPDATE_STRATEGY_MERGE && $initial->getDistType() !== 'path') {
$stashPath = $this->stashModuleDir($this->getInstallPath($initial));
if ($stashPath !== null) {
$basePath = sys_get_temp_dir().'/module-base-'.uniqid('', true);
}
} else {
// Overwrite: stash for rollback safety rather than deleting outright.
// $basePath stays null, which signals overwrite mode in the callbacks.
// Also covers initial=path: there's no remote dist to download as merge base,
// and stashing first would make the path inaccessible to PathDownloader.
$stashPath = $this->stashModuleDir($installPath);
}

Expand Down