Conversation
…ked method for clarity
There was a problem hiding this comment.
Pull request overview
This PR refactors the installer’s “path repository” detection by extracting the install-path checks into a new helper method, aiming to more clearly distinguish locally managed module directories from normal Packagist-installed modules.
Changes:
- Refactored
isPathRepository()to delegate install-path checks to a newisLocallyTracked(string $path)helper. - Added/updated docblocks to clarify which install paths should be protected from being overwritten.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| */ | ||
| protected function isLocallyTracked(string $path): bool | ||
| { | ||
| return is_link($path) || is_dir($path.'/.git'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic for detecting locally managed packages in the installer. The main change is the extraction of path repository detection into a new, more general method, improving code clarity and maintainability.
Refactoring and logic improvement:
isLocallyTracked, which determines if a given install path is either a symlink or a git-tracked directory. TheisPathRepositorymethod now delegates to this new method for improved clarity and reusability.