Skip to content

feat: add package registration logic for path repositories in install… #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roble merged 2 commits into from
May 21, 2026
Merged

feat: add package registration logic for path repositories in install… #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8f8714
feat: add package registration logic for path repositories in install…
roble May 15, 2026
16bc7c1
feat: implement package replacement logic for path repositories in up…
roble May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,10 @@ public function install(InstalledRepositoryInterface $repo, PackageInterface $pa
if ($this->isPathRepository($package)) {
$this->io->write(" - <info>Skipping install for path repository:</info> {$package->getPrettyName()}");

if (! $repo->hasPackage($package)) {
$repo->addPackage(clone $package);
}

return \React\Promise\resolve(null);
}

Expand Down Expand Up @@ -480,6 +484,14 @@ public function update(InstalledRepositoryInterface $repo, PackageInterface $ini
if ($this->isPathRepository($target)) {
$this->io->write(" - <info>Skipping update for path repository:</info> {$target->getPrettyName()}");

if ($repo->hasPackage($initial)) {
$repo->removePackage($initial);
}

if (! $repo->hasPackage($target)) {
$repo->addPackage(clone $target);
}

Comment on lines +491 to +494
return \React\Promise\resolve(null);
}

Expand Down
90 changes: 90 additions & 0 deletions tests/ModuleInstallerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,38 @@ public function test_install_logs_skip_message_and_returns_promise_for_path_repo
$this->assertNotNull($promise);
}

public function test_install_registers_package_in_repo_when_not_already_present_for_path_repo(): void
{
$io = $this->createStub(IOInterface::class);

$pkg = $this->createStub(PackageInterface::class);
$pkg->method('getDistType')->willReturn('path');
$pkg->method('getPrettyName')->willReturn('saucebase/test');

$repo = $this->createMock(InstalledRepositoryInterface::class);
$repo->method('hasPackage')->willReturn(false);
$repo->expects($this->once())->method('addPackage');

$installer = new TestableInstaller($io, null);
$installer->install($repo, $pkg);
}

public function test_install_does_not_register_package_in_repo_when_already_present_for_path_repo(): void
{
$io = $this->createStub(IOInterface::class);

$pkg = $this->createStub(PackageInterface::class);
$pkg->method('getDistType')->willReturn('path');
$pkg->method('getPrettyName')->willReturn('saucebase/test');

$repo = $this->createMock(InstalledRepositoryInterface::class);
$repo->method('hasPackage')->willReturn(true);
$repo->expects($this->never())->method('addPackage');

$installer = new TestableInstaller($io, null);
$installer->install($repo, $pkg);
}

// -------------------------------------------------------------------------
// update() path-repository guard
// -------------------------------------------------------------------------
Expand All @@ -624,6 +656,64 @@ public function test_update_logs_skip_message_and_returns_promise_for_path_repo(
$this->assertNotNull($promise);
}

public function test_update_registers_package_in_repo_when_not_already_present_for_path_repo(): void
{
$io = $this->createStub(IOInterface::class);

$initial = $this->createStub(PackageInterface::class);

$target = $this->createStub(PackageInterface::class);
$target->method('getDistType')->willReturn('path');
$target->method('getPrettyName')->willReturn('saucebase/test');

$repo = $this->createMock(InstalledRepositoryInterface::class);
$repo->method('hasPackage')->willReturn(false);
$repo->expects($this->never())->method('removePackage');
$repo->expects($this->once())->method('addPackage');

$installer = new TestableInstaller($io, null);
$installer->update($repo, $initial, $target);
}

public function test_update_replaces_initial_with_target_in_repo_for_path_repo(): void
{
$io = $this->createStub(IOInterface::class);

$initial = $this->createStub(PackageInterface::class);

$target = $this->createStub(PackageInterface::class);
$target->method('getDistType')->willReturn('path');
$target->method('getPrettyName')->willReturn('saucebase/test');

$repo = $this->createMock(InstalledRepositoryInterface::class);
$repo->method('hasPackage')
->willReturnCallback(fn (PackageInterface $pkg) => $pkg === $initial);
$repo->expects($this->once())->method('removePackage')->with($initial);
$repo->expects($this->once())->method('addPackage');

$installer = new TestableInstaller($io, null);
$installer->update($repo, $initial, $target);
}

public function test_update_does_not_register_package_in_repo_when_already_present_for_path_repo(): void
{
$io = $this->createStub(IOInterface::class);

$initial = $this->createStub(PackageInterface::class);

$target = $this->createStub(PackageInterface::class);
$target->method('getDistType')->willReturn('path');
$target->method('getPrettyName')->willReturn('saucebase/test');

$repo = $this->createMock(InstalledRepositoryInterface::class);
$repo->method('hasPackage')->willReturn(true);
$repo->expects($this->once())->method('removePackage')->with($initial);
$repo->expects($this->never())->method('addPackage');

$installer = new TestableInstaller($io, null);
$installer->update($repo, $initial, $target);
}

// -------------------------------------------------------------------------
// uninstall() path-repository guard
// -------------------------------------------------------------------------
Expand Down