Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how module selections are handled and passed through the install process, especially when using the Docker environment. It ensures that the
--modulesargument is always included (even when empty), improves matching logic for module names, and adds comprehensive tests to cover these scenarios.Module selection and argument handling:
DockerEnvironmentto always include the--modulesargument, using the provided option if set, or the selected modules otherwise. This prevents the interactive prompt in containers and ensures consistency.InstallCommand::promptForModules()to correctly detect when the--modulesoption is present (even if set to an empty string or zero), preventing unnecessary prompts.Module name matching improvements:
InstallCommand::resolveModuleSelection()to match both full package names and short names (with case insensitivity), making module selection more flexible and user-friendly.Test coverage:
DockerEnvironmentTestto verify that--modulesis always included, whether modules are selected or not, and that the option is forwarded correctly when set directly. [1] [2]InstallCommandTestto ensure module selection works for full names, short names, mixed case, and multiple modules.