Skip to content

fix: improve module selection handling in InstallCommand and DockerEn…#7

Merged
roble merged 1 commit into
mainfrom
dev
Jun 25, 2026
Merged

fix: improve module selection handling in InstallCommand and DockerEn…#7
roble merged 1 commit into
mainfrom
dev

Conversation

@roble

@roble roble commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This pull request improves how module selections are handled and passed through the install process, especially when using the Docker environment. It ensures that the --modules argument is always included (even when empty), improves matching logic for module names, and adds comprehensive tests to cover these scenarios.

Module selection and argument handling:

  • Updated DockerEnvironment to always include the --modules argument, using the provided option if set, or the selected modules otherwise. This prevents the interactive prompt in containers and ensures consistency.
  • Changed the logic in InstallCommand::promptForModules() to correctly detect when the --modules option is present (even if set to an empty string or zero), preventing unnecessary prompts.

Module name matching improvements:

  • Enhanced InstallCommand::resolveModuleSelection() to match both full package names and short names (with case insensitivity), making module selection more flexible and user-friendly.

Test coverage:

  • Added and updated tests in DockerEnvironmentTest to verify that --modules is always included, whether modules are selected or not, and that the option is forwarded correctly when set directly. [1] [2]
  • Added comprehensive tests in InstallCommandTest to ensure module selection works for full names, short names, mixed case, and multiple modules.

@roble roble merged commit 5b1cffa into main Jun 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant