Conversation
…nt class and updating Docker/Native environments to extend it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and enhances the Saucebase installation workflow, focusing on improving module installation, Docker environment handling, and code organization. The main changes include moving and generalizing cross-module import rewriting, streamlining module installation (with better handling of fully qualified names and seeders), and refactoring the environment abstraction for better extensibility and error handling.
Installer Workflow and Module Management Improvements:
rewriteCrossModuleImportsmethod inInstallCommand, supporting multiple frameworks and used after module installation. (src/Console/Commands/InstallCommand.php,src/Console/Commands/StackCommand.php) [1] [2] [3]moduleHasSeedermethod). (src/Console/Commands/InstallCommand.php) [1] [2] [3]displaySuccessmethod now optionally lists next steps, supporting dynamic instructions from environments. (src/Console/Commands/InstallCommand.php)Environment Abstraction and Docker Flow Refactor:
Environmentinterface is now an abstract class, moved out ofContracts, and inherited by environment implementations. (src/Environments/Contracts/Environment.php,src/Environments/DockerEnvironment.php,src/Console/Commands/InstallCommand.php) [1] [2] [3]beforePrompts, with improved SSL/mkcert guidance.bool), and only proceeds if successful.src/Environments/DockerEnvironment.php) [1] [2] [3]Code Cleanup and Robustness:
reloadDocker,commandExistsin Docker), improved error/warning messages, and added checks for existing app keys and file operations. (src/Environments/DockerEnvironment.php) [1] [2] [3] [4] [5]These changes collectively make the installation process more robust, maintainable, and user-friendly, especially when using Docker and managing modules.