Conversation
refactor(AuthDatabaseSeeder): simplify user creation and remove unused admin role assignment fix(login.security): configure test.describe for serial execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Artisan command to promote users to admin, along with supporting tests and improvements to developer tooling. It also updates the auth database seeder and makes minor adjustments to E2E test configuration.
New Admin Promotion Command:
auth:make-adminArtisan command (MakeAdminCommand) to promote an existing user to admin, with argument validation and clear output.Taskfile.ymlunder themake-admintask for easy execution.Testing:
MakeAdminCommandTest) to ensure the new command works correctly, including scenarios for successful promotion, user-not-found, role replacement, and idempotency.Database Seeding:
AuthDatabaseSeederto only create a default user with theuserrole, removing automatic assignment of theadminrole and test user creation.Developer Tooling:
Taskfile.ymlto consistently use the{{.APP}}variable for environment compatibility.E2E Test Configuration: