Repository navigation
feat(admin-ui): prototype UI5 Component-preload build (puzzles tile) - #2748
Merged
Merged
Conversation
…nents Opt-in via PRELOAD_COMPONENTS set in copy-components.js (currently just 'puzzles', the heaviest tile). Listed components run through 'ui5 build' (emits minified Component-preload.js); all others keep the raw cpSync path. Proven on puzzles: ~10 per-module round-trips -> ~2 (preload + manifest), each round-trip being a full XSUAA-authed approuter hit with no CDN. Worker file (lib/fill-worker.js) stays standalone so new Worker(toUrl()) still resolves. Shell bootstrap is data-sap-ui-async=true, so UI5 uses the preload. Prototype only - needs a live DEV deploy to confirm the preload loads under the approuter CSP before fanning out to the other 13 tiles.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Opt-in UI5
Component-preload.jsbuild for admin-shell component tiles.app/admin-shell/scripts/copy-components.jsnow has aPRELOAD_COMPONENTSset — listed components run throughui5 build(minify +generateComponentPreload) instead of rawcpSync; all others are unchanged. Currently justpuzzles, the heaviest tile (43 KB controller + Web Worker + 5 lib modules).Why
Each headless componentUsage currently loads every module as a separate request, and each request is a full XSUAA-authed approuter hit with no CDN. A preload collapses that.
Measured on
puzzles(real build):Why plain
ui5 build(not--all/self-contained)--allbuilds the entire SAPUI5 framework (27 projects incl. theme.less) and fails on missing theme sources — we don't want the framework.self-containedcan drop standalone raw files;puzzlesloads its Web Worker vianew Worker(sap.ui.require.toUrl("...fill-worker.js")), which needs the physical file. Plainui5 buildkeeps it.Verified statically
dist/components/puzzles/Component-preload.js; the other 50 components untouched.resourceRoots/componentUsages(lazy: true) point at the right dir; bootstrap isdata-sap-ui-async="true"(required for UI5 to use the preload).NOT yet verified — this is the point of merging to DEV
scripts/check-shipped-admin-bundle.cjs) diffs shipped files vs source and will flag preloaded output as drift — expect the deploy guard to need updating.puzzles→ invalid controller JS would fail at the minify step (previously only caught at deploy).Follow-up items tracked in #2749.