Skip to content

fix(hana-cloud-cap-add-authentication): close Step 4 JSON fence - #24243

Merged
jung-thomas merged 1 commit into
masterfrom
fix/hana-cloud-cap-add-authentication-step4-json-fence
Oct 12, 2026
Merged

jung-thomas merged 1 commit into
masterfrom
fix/hana-cloud-cap-add-authentication-step4-json-fence

Conversation

@jung-thomas

Copy link
Copy Markdown
Contributor

Problem

Fixes sap-tutorials/tutorials-ims#2721.

In hana-cloud-cap-add-authentication ("Add User Authentication to Your Application (SAP HANA Cloud)"), Step 4's Done button and the entire Step 5 are missing from the rendered tutorial. The progress bar shows 5 steps but only Steps 1–3 are usable.

Root cause

Step 4's xs-app.json fenced code block is a list-continuation fence indented 3 spaces under 1. Next open the xs-app.json file.... The opening fence ```json, every sibling top-level line, and the closing } are all at 3 spaces — but the block's opening brace { was indented only 2 spaces:

   ```json
  {                       <-- 2 spaces (wrong)
   "authenticationMethod": "route",
   ...

Under CommonMark / Hugo-Goldmark, a continuation line indented less than the opening fence falls outside the list-item content column. Goldmark therefore closes the code block immediately (emitting an empty <code class="language-json">), spills the JSON out as a plain prose paragraph (with the quotes smart-quoted), and reopens a second stray empty code block at the trailing ```. The resulting broken HTML structure collapses Step 4's Done button and swallows Step 5 in the browser.

Verified by rendering the before/after through the actual Hugo (extended, Goldmark) engine: the broken version yields an empty language-json block + stranded <p>{... prose; the one-character fix produces a single well-formed code block.

Fix

Indent the opening { from 2 → 3 spaces so it aligns with the fence and all sibling lines. One-line, content-only change.

Mirror

This is one half of a mirrored pair (Contribution ↔ canonical Tutorials); content is byte-for-byte identical in both PRs.

Mirror of https://github.com/sap-tutorials/Tutorials-Contribution/pull/42169

@jung-thomas
jung-thomas merged commit 9610a5c into master Oct 12, 2026
1 check passed
@sap-tutorials-builder

Copy link
Copy Markdown
Contributor

✅ No issues found

Checked 88731c4 • notify-only, does not block merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feedback]: [hana-cloud-cap-add-authentication] Step 4 and Step 5 broken / swallowed by unclosed markdown code block in Step 4

1 participant