Repository navigation
fix(hana-cloud-cap-add-authentication): close Step 4 JSON fence - #24243
Merged
jung-thomas merged 1 commit intoOct 12, 2026
Merged
Conversation
…nt brace to 3 spaces)
Contributor
|
✅ No issues found Checked 88731c4 • notify-only, does not block merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes sap-tutorials/tutorials-ims#2721.
In
hana-cloud-cap-add-authentication("Add User Authentication to Your Application (SAP HANA Cloud)"), Step 4's Done button and the entire Step 5 are missing from the rendered tutorial. The progress bar shows 5 steps but only Steps 1–3 are usable.Root cause
Step 4's
xs-app.jsonfenced code block is a list-continuation fence indented 3 spaces under1. Next open the xs-app.json file.... The opening fence```json, every sibling top-level line, and the closing}are all at 3 spaces — but the block's opening brace{was indented only 2 spaces:Under CommonMark / Hugo-Goldmark, a continuation line indented less than the opening fence falls outside the list-item content column. Goldmark therefore closes the code block immediately (emitting an empty
<code class="language-json">), spills the JSON out as a plain prose paragraph (with the quotes smart-quoted), and reopens a second stray empty code block at the trailing```. The resulting broken HTML structure collapses Step 4's Done button and swallows Step 5 in the browser.Verified by rendering the before/after through the actual Hugo (extended, Goldmark) engine: the broken version yields an empty
language-jsonblock + stranded<p>{...prose; the one-character fix produces a single well-formed code block.Fix
Indent the opening
{from 2 → 3 spaces so it aligns with the fence and all sibling lines. One-line, content-only change.Mirror
This is one half of a mirrored pair (Contribution ↔ canonical
Tutorials); content is byte-for-byte identical in both PRs.Mirror of https://github.com/sap-tutorials/Tutorials-Contribution/pull/42169