Repository navigation
fix(runtime): prepare only the Session-selected Harness - #12
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Core-managed Codex Session previously waited for Codex, MiniMax Code and Claude SDK discovery before its Runtime connected, even though all three were packaged only to share one template. Carry the owning Session’s immutable Harness through Runtime bootstrap and discover/register only that selection. Unknown or unavailable selections fail without probing another implementation; self-hosted installations retain their installed Harness set.
The bootstrap codec is version 2 with required
harness. E2B and microsandbox helpers use version 3; node wire uses version 6 with exact, unique nested Bootstrap members. E2B’s managed launch file delivers the selection only inside RuntimeBootstrap. Core–Runtime wire, SQL/schema and native dependency pins are unchanged. Publish matching Core/helpers/new Runtime template together; node installations need matching nodes. Existing allocations retain their bootstrap and Runtime.Codex still validates
--version; safe process-spawn/wait timings distinguish its cold probe. Existing production diagnostic evidence showed serial discovery at 16.537 seconds and warm Codex version commands at 49.6/11.0 milliseconds. These are baseline observations, not acceptance or a latency claim for this change.Validation: selected/unknown/unavailable discovery and strict startup/node codec tests (including race repeats), Provider regressions, Core–Runtime contract checks, 199 E2B Python tests against the pinned SDK, isolated PostgreSQL Session-selection/replay/suspension tests, vet, docs/name/translation checks and independent review. A fresh-template cloud execution test has not been performed.
CI passed all selected checks, including Core/Runtime, all store shards, official-client, compose/distribution, website and Linux/macOS/Windows platform checks. CI run.