Repository navigation
Gentoo fixes - #2614
Merged
Merged
Gentoo fixes#2614
Conversation
With --disable-bcftools-plugins, configure leaves PLUGIN_EXT empty, so `plugins/*$(PLUGIN_EXT)` in the install rule expands to `plugins/*` and copies every plugin .c/.mk source file into $(plugindir). Only create $(plugindir) and install plugins when they were actually built.
test_trio_dnm3 needs the trio-dnm3 plugin, but unlike every other plugin test it is not guarded by --plugins, so it fails when bcftools is built with --disable-bcftools-plugins.
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_trio_dnm3unless plugin tests are enabled