Fix postgres execution not respecting configuration values - #69973
Open
nicholas-rees wants to merge 1 commit into
Open
Fix postgres execution not respecting configuration values#69973nicholas-rees wants to merge 1 commit into
nicholas-rees wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modifies the postgres execution module to respect the configuration set by changing all calls from
config.optiontoconfig.getand setting the string delimiters to colons.As noted in the related issue I opened:
It seems like
config.optionis just the wrong function to use andconfig.getis the correct one.Before this fix:
After:
I do not know if this should go in the 3006.x. I sort of suspect that it should but I have not tested this at all on 3006.x so I have made this PR. If you would like to change it to 3006.x let me know and I can do that work.
What issues does this PR fix or reference?
Fixes #69971
Previous Behavior
postgres module was not respecting the configuration set in either the pillars or minion configuration file.
New Behavior
postgres module now respects configuration values.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes