fix: surface insufficient access error on org delete sandbox#1647
Open
ZLeventer wants to merge 1 commit intosalesforcecli:mainfrom
Open
fix: surface insufficient access error on org delete sandbox#1647ZLeventer wants to merge 1 commit intosalesforcecli:mainfrom
ZLeventer wants to merge 1 commit intosalesforcecli:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user without the "Manage Sandboxes" system permission runs
sf org delete sandbox, the Tooling API returnsINSUFFICIENT_ACCESS_OR_READONLY. Currently that error propagates as an unhandled exception with a raw API message.This PR catches that specific error code in the existing
catchblock and surfaces it as a cleanSfErrorwith an actionable message pointing the user to their Salesforce admin.Why not a pre-flight permission check?
org.delete()operates against the production org's Tooling API — checking a PermissionSet on the sandbox org (as proposed in #1565) would query the wrong org. Catching the real API error after the fact is simpler, always targets the right org, requires no custom PermissionSet setup by customers, and handles the case where permissions change between the check and the actual delete.Closes #1565 (alternative approach)