refactor: devScripts update

eslint.config.mjs

@@ -0,0 +1,21 @@
+import tsconfigs from 'eslint-config-salesforce-typescript';
+import plugin from 'eslint-plugin-sf-plugin';
+
+const configs = [
+  ...tsconfigs,
+  ...plugin.configs.recommended,
+  {
+    rules: {
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          caughtErrorsIgnorePattern: '^_',
+        },
+      ],
+    },
+  },
+];
+
+export default configs;

package.json

@@ -7,7 +7,7 @@
   "enableO11y": true,
   "o11yUploadEndpoint": "https://794testsite.my.site.com/byolwr/webruntime/log/metrics",
   "dependencies": {
-    "@inquirer/input": "^2.3.0",
+    "@inquirer/prompts": "^7.10.1",
     "@jsforce/jsforce-node": "^3.10.22",
     "@oclif/core": "^4",
     "@salesforce/core": "^9.1.4",
@@ -24,16 +24,22 @@
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^5.3.34",
     "@salesforce/cli-plugins-testkit": "^5.3.64",
-    "@salesforce/dev-scripts": "^11.0.4",
+    "@salesforce/dev-scripts": "^13.0.2",
     "@salesforce/plugin-command-reference": "^3.1.132",
     "@salesforce/ts-sinon": "^1.4.36",
     "@salesforce/ts-types": "^3.0.1",
+    "@types/chai": "^4.3.17",
     "@types/marked": "^4.0.8",
     "@types/marked-terminal": "^3.1.3",
+    "@types/mocha": "^10.0.10",
+    "@types/node": "^18",
     "@types/semver": "^7.8.0",
-    "@types/which": "^3",
+    "@types/sinon": "^10.0.20",
     "@types/sinon-chai": "^3.2.12",
-    "eslint-plugin-sf-plugin": "^1.20.33",
+    "@types/which": "^3",
+    "eslint": "^10.4.0",
+    "eslint-config-salesforce-typescript": "^6.0.0",
+    "eslint-plugin-sf-plugin": "^3.0.0",
     "oclif": "^4.23.30",
     "sinon-chai": "^3.7.0",
     "ts-node": "^10.9.2",
@@ -148,6 +154,7 @@
         "src/**/*.ts",
         "test/**/*.ts",
         "messages/**",
+        "**/eslint.config.*",
         "**/.eslint*",
         "**/tsconfig.json"
       ],

src/diagnostics.ts

@@ -163,7 +163,7 @@ export class Diagnostics {
           const conn = new Connection();
           await conn.request(url);
           await Lifecycle.getInstance().emit('Doctor:diagnostic', { testName: `can access: ${url}`, status: 'pass' });
-        } catch (e) {
+        } catch (_e) {
           await Lifecycle.getInstance().emit('Doctor:diagnostic', { testName: `can't access: ${url}`, status: 'fail' });
           this.doctor.addSuggestion(
             `Cannot reach ${url} - potential network configuration error, check proxies, firewalls, environment variables`
@@ -180,7 +180,7 @@ export class Diagnostics {
         testName: `can access: ${manifestUrl}`,
         status: 'pass',
       });
-    } catch (e) {
+    } catch (_e) {
       await Lifecycle.getInstance().emit('Doctor:diagnostic', {
         testName: `can't access: ${manifestUrl}`,
         status: 'fail',

src/shared/prompts.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import input from '@inquirer/input';
+import { input } from '@inquirer/prompts';
 
 // a wrapper object to make inquirer prompts stubbable by sinon
 export const prompts = {

test/commands/doctor.test.ts

@@ -170,7 +170,7 @@ describe('Doctor Command', () => {
   afterEach(() => {
     sandbox.restore();
     // Reset the instance for testing
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment,@typescript-eslint/no-unsafe-assignment
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     delete Doctor.instance;
   });

test/diagnostics.test.ts

@@ -88,7 +88,7 @@ describe('Diagnostics', () => {
   afterEach(() => {
     sandbox.restore();
     // Reset the instance for testing
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment,@typescript-eslint/no-unsafe-assignment
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     delete Doctor.instance;
   });

test/doctor.test.ts

@@ -71,7 +71,7 @@ describe('Doctor Class', () => {
   afterEach(() => {
     sandbox.restore();
     // Reset the instance for testing
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment,@typescript-eslint/no-unsafe-assignment
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     delete Doctor.instance;
   });

test/shared/getInfoConfig.test.ts

@@ -48,7 +48,7 @@ describe('getInfoConfig tests', () => {
           },
         },
       },
-    } as PjsonWithInfo;
+    };
 
     // keep pjsonMock as JSON to access values in tests
     readFileStub = stubMethod(sandbox, fs.promises, 'readFile').resolves(JSON.stringify(pjsonMock));