fix: resolve path hijack (W-23905795) - #539
Merged
Merged
Conversation
jfeingold35
commented
Aug 18, 2026
| const resolvedCmd = [resolved.toString(), ...args.slice(1)].join(' '); | ||
|
|
||
| this.logger.debug(`Executing command: ${resolvedCmd}`); | ||
| shelljs.exec(resolvedCmd, { cwd: this.cwd }); |
Contributor
Author
There was a problem hiding this comment.
Long-term, we should aim to replace all of the shelljs uses with cross-spawn. However, the other invocations didn't seem to have this specific vulnerability, and I didn't want to gut the package so close to moratorium, so I just kept the fix minimal.
jfeingold35
force-pushed
the
d/W-23905795
branch
from
August 19, 2026 15:42
842648f to
d35b335
Compare
soridalac
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses a security vulnerability for Windows wherein the folder path could contain malicious command injection.
What issues does this PR fix or reference?
@W-23905795@