Repository navigation
Update branch for replacing import in T19 - #69
Closed
sabernhardt wants to merge 236 commits into
Closed
sabernhardt wants to merge 236 commits into
sabernhardt wants to merge 236 commits into
Conversation
The WordPress inline documentation standards for PHP and JavaScript reserve `@see` for references to functions, methods, classes, and hooks, and use `@link` for URLs. While phpDocumentor and JSDoc both accept a URL in `@see`, core had used both forms for external references such as specifications, Trac tickets, and GitHub pull requests, so the remaining `@see` tags pointing to URLs are converted to `@link` across core, the bundled themes, core scripts, and the unit tests. On the touched lines, `@see` is kept ahead of `@link` where both appear, per the standards; links to developer.wordpress.org pages for core functions in Twenty Twenty become `@see` references to those functions; and links that no longer resolve are updated. The block files synced from Gutenberg, the bundled pomo library, and other third-party code are left unchanged, and the HTML API is handled separately. Developed in #10804. Follow-up to r63569. Props huzaifaalmesbah, westonruter, noruzzaman, shailu25. See #65860. git-svn-id: https://develop.svn.wordpress.org/trunk@64436 602fd350-edb4-49c9-b593-d223f7449a82
The target schema of the `https://api.w.org/action-unfiltered-html` link description object nested `raw` directly under `content`, without the `type` and `properties` keywords. `raw` isn't a JSON Schema keyword, so the schema put no constraint on `content`. Wraps `raw` in an object schema, like the `content` property of the post schema, and adds a test for it. Developed in #14362. Follow-up to [43974]. Props jorgefilipecosta. Fixes #66332. git-svn-id: https://develop.svn.wordpress.org/trunk@64437 602fd350-edb4-49c9-b593-d223f7449a82
The Connectors screen requested the site settings, the `OPTIONS` response of the plugins endpoint, and the records of the AI plugin and of each connector's plugin only after its scripts loaded, which delayed its first render. Adds the private `_wp_connectors_preload_paths()` callback to the `wp_options_connectors_wp_admin_preload_paths` filter, so these responses are embedded in the page. Only successful responses are preloaded, so the screen still requests the records of plugins that aren't installed. The filter is applied by the page that the Gutenberg build generates, so the preloading takes effect once the pinned Gutenberg version includes WordPress/gutenberg#77353. Developed in #11790 and WordPress/gutenberg#77353. Props westonruter, wildworks, jorgefilipecosta, mukesh27, apermo, ugyensupport, gziolo, justlevine, peterwilsoncc, ellatrix, cbravobernal. Fixes #65215. git-svn-id: https://develop.svn.wordpress.org/trunk@64438 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/formatting/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Use static properties for the emoji CDN fixture values. Developed in: #14381 Props rejaulalomkhan, mukesh27. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64439 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/functions/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Make the daylight-saving-time helper static so the timezone provider does not require an instance. Developed in: #14382 Props rejaulalomkhan, huzaifaalmesbah. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64440 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/admin/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Update direct calls to the submenu provider to use `self::`. Developed in: #14389 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64441 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/bookmark/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Developed in: #14391 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64442 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/sitemaps/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Developed in: #14392 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64443 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/comment/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Developed in: #14393 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64444 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/term/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Call the existing static `text_array_to_dataprovider()` helper with `self::`. Developed in: #14395 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64445 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/compat/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Developed in: #14396 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64446 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/date/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Developed in: #14397 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64447 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/fonts/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Developed in: #14400 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64448 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/block-supports/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Developed in: #14398 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64449 602fd350-edb4-49c9-b593-d223f7449a82
Declare the data providers in `tests/phpunit/tests/canonical/` as `public static` for compatibility with newer PHPUnit versions. Preserve their datasets and assertions. Developed in: #14399 Props rejaulalomkhan. See #66211. git-svn-id: https://develop.svn.wordpress.org/trunk@64450 602fd350-edb4-49c9-b593-d223f7449a82
Replace the empty `test_prepare_item()` stub with assertions for page fields in the edit context and the `self`, `collection`, and `about` links returned by `WP_REST_Posts_Controller::prepare_item_for_response()`. Developed in: #14384 Props rejaulalomkhan, huzaifaalmesbah. See #40538. git-svn-id: https://develop.svn.wordpress.org/trunk@64451 602fd350-edb4-49c9-b593-d223f7449a82
Replace the empty `test_prepare_item()` stub with assertions for the navigation ID, response status, and embeddable `self` link returned by `WP_REST_Navigation_Fallback_Controller::prepare_item_for_response()`. Verify that requesting only `id` through `_fields` omits links. Developed in: #14385 Props rejaulalomkhan. See #40538, #66073. git-svn-id: https://develop.svn.wordpress.org/trunk@64452 602fd350-edb4-49c9-b593-d223f7449a82
Check leading and trailing whitespace, whitespace-only values, encoded separators, and character-reference boundaries in `class_list()`. Prevent empty class names and incorrect decoding from passing unnoticed. Developed in: #14300 Props jonsurrell. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64453 602fd350-edb4-49c9-b593-d223f7449a82
Verify importer mappings, blog and user selection, request options, quota handling, and command-line argument parsing. Cover the 100-row boundary in `get_imported_posts()`. Developed in: #14327 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64454 602fd350-edb4-49c9-b593-d223f7449a82
Verify that `extract_serialized_parent_block()` retains the outer block and `remove_serialized_parent_block()` returns its inner content across nested blocks, attributes, comments, and whitespace. Developed in: #14331 Props rejaulalomkhan. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64455 602fd350-edb4-49c9-b593-d223f7449a82
Covers category lookup by ID and object, array output, edit-con filtering, and invalid or wrong-taxonomy inputs. Developed in: #14363 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64456 602fd350-edb4-49c9-b593-d223f7449a82
Checks direct and indirect ancestry, unrelated categories, and term IDs from another taxonomy. Developed in: #14364 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64457 602fd350-edb4-49c9-b593-d223f7449a82
…t is not set.
This resolves an error if `mysqli_num_fields()` is called before a successful SELECT-type query is performed:
{{{
mysqli_num_fields(): Argument #1 ($result) must be of type mysqli_result, false given
}}}
Developed in #13099.
Follow-up to r21472.
Props joehorntw, akshat2802, mukesh27, rejaulalomkhan, SergeyBiryukov.
Fixes #64130.
git-svn-id: https://develop.svn.wordpress.org/trunk@64458 602fd350-edb4-49c9-b593-d223f7449a82
Verifies category cache invalidation and its action, plus regeneration of the category hierarchy option. Developed in: #14365 Props shailu25, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64459 602fd350-edb4-49c9-b593-d223f7449a82
Covers object and array sanitization, filter arguments, and preservation of unset fields. Developed in: #14366 Props shailu25, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64460 602fd350-edb4-49c9-b593-d223f7449a82
Checks field casting, con-specific filters and escaping, including the database slug path. Developed in: #14367 Props shailu25, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64461 602fd350-edb4-49c9-b593-d223f7449a82
Covers post ID and global-post lookup, empty results, compatibility properties, and the categories filter. Developed in: #14368 Props shailu25, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64462 602fd350-edb4-49c9-b593-d223f7449a82
Checks matching and missing categories, the empty-category case, global-post fallback, and invalid posts. Developed in: #14369 Props shailu25, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64463 602fd350-edb4-49c9-b593-d223f7449a82
Check capability and registration decisions for core submenus, plugin pages, hidden pages, and parent-menu fallbacks. Restore menu and request globals between cases. Developed in: #14372 Props huzaifaalmesbah, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64464 602fd350-edb4-49c9-b593-d223f7449a82
Checks the default category list and custom separator, parent, and post-ID output. Developed in: #14373 Props shailu25, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64465 602fd350-edb4-49c9-b593-d223f7449a82
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: #14562 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64644 602fd350-edb4-49c9-b593-d223f7449a82
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: #14563 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64645 602fd350-edb4-49c9-b593-d223f7449a82
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: #14564 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64646 602fd350-edb4-49c9-b593-d223f7449a82
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: #14565 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64647 602fd350-edb4-49c9-b593-d223f7449a82
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: #14566 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64648 602fd350-edb4-49c9-b593-d223f7449a82
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: #14568 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64649 602fd350-edb4-49c9-b593-d223f7449a82
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: #14567 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64650 602fd350-edb4-49c9-b593-d223f7449a82
Add coverage for `install_plugin_install_status()`, including installed versions, update checks, capability-dependent URLs, and query arguments. Clean up plugin fixtures and multisite super-admin grants after testing. Developed in: #14520 Props huzaifaalmesbah, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64651 602fd350-edb4-49c9-b593-d223f7449a82
Test `WP_Plugins_List_Table::get_bulk_actions()` across plugin statuses, capabilities, auto-update settings, and multisite screens. Include the actual `recently_activated` status and restore the super-admin grant after the class. Developed in: #14524 Props huzaifaalmesbah, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64652 602fd350-edb4-49c9-b593-d223f7449a82
Use `assertWPError()` in the Customizer navigation menu tests. Preserve the existing error-code and successful-result assertions. Developed in: #14570 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64653 602fd350-edb4-49c9-b593-d223f7449a82
Use `assertWPError()` when checking invalid URLs in the Customizer navigation menu item setting tests. Preserve the `invalid_url` error-code checks. Developed in: #14571 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64654 602fd350-edb4-49c9-b593-d223f7449a82
Use `assertWPError()` when unregistering an unknown block template. Preserve the assertion that the error message includes the template name. Developed in: #14572 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64655 602fd350-edb4-49c9-b593-d223f7449a82
Use `assertWPError()` for authentication and password reset failures. Preserve the existing error-code and success-path checks. Developed in: #14573 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64656 602fd350-edb4-49c9-b593-d223f7449a82
Use `assertWPError()` in the Customizer manager tests. Preserve the existing error-code, validation, error-data, and changeset persistence checks. Developed in: #14569 Props devmuhib. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64657 602fd350-edb4-49c9-b593-d223f7449a82
Recognize REST media-creation responses alongside classic multipart uploads when waiting for a JPEG upload. Extract the attachment ID from either response format while excluding requests for attachment markup. This fixes the timeout introduced when browser uploads began using the REST API in [64588]. Preserve the completed-title and Edit-link assertions and attachment cleanup. Developed in: #14575 Props adrianmoldovanwp. See #52895. git-svn-id: https://develop.svn.wordpress.org/trunk@64658 602fd350-edb4-49c9-b593-d223f7449a82
Add coverage for `WP_Plugin_Dependencies::check_plugin_dependencies_during_ajax()`, including nonce validation, missing plugins, activation capabilities, dependency states, and multisite activation URLs. Restore dependency caches and revoke the class fixture's super-admin grant after testing. Developed in: #14521 Props huzaifaalmesbah, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64659 602fd350-edb4-49c9-b593-d223f7449a82
Add coverage for `Plugin_Installer_Skin::do_overwrite()`, including comparison markup, update and downgrade actions, unmet requirements, and filtered output. Verify that `after()` stops after displaying the overwrite screen. Developed in: #14576 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64660 602fd350-edb4-49c9-b593-d223f7449a82
Add coverage for `Plugin_Upgrader::check_package()`, including invalid packages, plugin header discovery, remote path mapping, and unmet PHP and WordPress requirements. Verify uploaded plugin data and restore the filesystem global after each test. Developed in: #14577 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64661 602fd350-edb4-49c9-b593-d223f7449a82
Test `wp_plugin_update_row()` and `wp_plugin_update_rows()` across update availability, permissions, package and PHP requirements, escaped output, links, hooks, and multisite screens. Developed in: #14578 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64662 602fd350-edb4-49c9-b593-d223f7449a82
Test `wp_get_update_data()` for plugin, theme, core, and translation updates, including permissions, dismissed core updates, singular and plural titles, and filtered results. Developed in: #14579 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64663 602fd350-edb4-49c9-b593-d223f7449a82
Test `WP_Site_Health::detect_plugin_theme_auto_update_issues()` across plugin and theme auto-update filters, settings visibility, reported statuses, and filter arguments. Developed in: #14580 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64664 602fd350-edb4-49c9-b593-d223f7449a82
Test the plugin sections produced by `WP_Debug_Data`, including must-use plugins, active and inactive plugins, available updates, auto-update settings, and filtered debug strings. Developed in: #14583 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64665 602fd350-edb4-49c9-b593-d223f7449a82
Test `WP_Plugin_Dependencies::get_circular_dependencies()` and `WP_Plugin_Dependencies::check_for_circular_dependencies()` for cached results, acyclic dependencies, missing plugins, and dependency cycles. Developed in: #14584 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64666 602fd350-edb4-49c9-b593-d223f7449a82
Test `WP_Site_Health::get_test_plugin_version()` for active and inactive plugins, available updates, singular and plural descriptions, update links, and multisite behavior. Developed in: #14582 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64667 602fd350-edb4-49c9-b593-d223f7449a82
Test `WP_Plugins_List_Table::no_items()` for empty views, search terms, escaped output, directory links, installation permissions, and multisite behavior. Developed in: #14585 Props huzaifaalmesbah. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64668 602fd350-edb4-49c9-b593-d223f7449a82
…heme_JSON`. See #65860. git-svn-id: https://develop.svn.wordpress.org/trunk@64669 602fd350-edb4-49c9-b593-d223f7449a82
For backward compatibility, `register_setting()` still accepts a sanitize callback as its third argument, converting it into the `sanitize_callback` argument without a deprecation notice. Its docblock documented `$args` only as an array, so once PHPStan began reading the hash notation in r63420, callers passing a callback were reported, such as Twenty Eleven and the deprecated `add_option_update_handler()`. This form remains in wide use across thousands of plugins and themes in the theme & plugin directories. Developed in #14137. Follow-up to r38635, r63420. Props jorgefilipecosta, westonruter. See #65817, #65860. git-svn-id: https://develop.svn.wordpress.org/trunk@64670 602fd350-edb4-49c9-b593-d223f7449a82
This update adds four and removes five certificates to the bundle. Props westonruter, peterwilsoncc. Fixes #66355. git-svn-id: https://develop.svn.wordpress.org/trunk@64671 602fd350-edb4-49c9-b593-d223f7449a82
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.