Skip to content

Explain surprising changes at review time - #7

Draft
ryanmagoon wants to merge 3 commits into
mainfrom
codex/explain-surprising-choices
Draft

Explain surprising changes at review time#7
ryanmagoon wants to merge 3 commits into
mainfrom
codex/explain-surprising-choices

Conversation

@ryanmagoon

@ryanmagoon ryanmagoon commented Aug 4, 2026

Copy link
Copy Markdown
Owner

What changed

  • Require inline reviewer context when a dependency, flag, workaround, suppression, or implementation choice looks surprising without additional context.
  • Require user-level configuration changes to go through the chezmoi source, diff, dry-run, and apply workflow.
  • Treat the dotfiles source and every related GitHub surface as public, and keep non-public business information and private origin context out of them.

Why

These rules keep rendered configuration reproducible across machines, reduce the amount of intent reviewers have to reconstruct, and make the public-repository boundary explicit.

Validation

  • Reviewed the source and rendered diffs.
  • Ran a scoped chezmoi dry run and apply.
  • Confirmed the managed target matches the source.
  • Scanned the complete PR diff and description for non-public identifiers and context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant