Skip to content

Type catch-all HookLoader extras as <mixed, mixed> #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruudk merged 1 commit into from
May 28, 2026
Merged

Type catch-all HookLoader extras as <mixed, mixed> #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Generator/DataClassGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ private function dumpLoadersShape(array $batchedHooks, array $plansByFqcn, CodeG
// which holds every batched hook in the operation, not just the subset a
// single nested class consumes. Extras are typed wide; HookLoader's
// covariant template params let any specific instantiation fit here.
$entries[] = sprintf('...<string, %s<array{...}, mixed>>', $hookLoader);
$entries[] = sprintf('...<string, %s<mixed, mixed>>', $hookLoader);

return sprintf("array{\n %s,\n}", implode(",\n ", $entries));
}
Expand Down
2 changes: 1 addition & 1 deletion tests/HooksBatched/Generated/Query/Test/Data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ final class Data
* findOrgPlan: HookLoader<array{string}, OrgPlan>,
* computeAccess: HookLoader<array{string, string}, Access>,
* findUserById: HookLoader<array{string}, null|User>,
* ...<string, HookLoader<array{...}, mixed>>,
* ...<string, HookLoader<mixed, mixed>>,
* }
*/
private readonly array $loaders;
Expand Down
2 changes: 1 addition & 1 deletion tests/HooksBatched/Generated/Query/Test/Data/Organization.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ final class Organization
* findOrgPlan: HookLoader<array{string}, OrgPlan>,
* computeAccess: HookLoader<array{string, string}, Access>,
* findUserById: HookLoader<array{string}, null|User>,
* ...<string, HookLoader<array{...}, mixed>>,
* ...<string, HookLoader<mixed, mixed>>,
* } $loaders
*/
public function __construct(
Expand Down
2 changes: 1 addition & 1 deletion tests/HooksBatched/Generated/Query/Test/Data/Organization/Repository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ final class Repository
* @param array{
* computeAccess: HookLoader<array{string, string}, Access>,
* findUserById: HookLoader<array{string}, null|User>,
* ...<string, HookLoader<array{...}, mixed>>,
* ...<string, HookLoader<mixed, mixed>>,
* } $loaders
*/
public function __construct(
Expand Down
Loading