doc: amend description to point to CertificateParams for additional explanation#433
Merged
Conversation
cpu
reviewed
May 26, 2026
cpu
left a comment
cpu
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I think it's a good idea but had nits to consider for the impl.
cpu
force-pushed
the
csr-doc-extend
branch
2 times, most recently
from
63f0e0b to
15c2eda
Compare
Member
I pushed the requested changes myself. Hope you don't mind. The nits were tiny and it seemed silly to leave this sitting around for another 2 weeks for minor adjustments. |
djc
approved these changes
Jun 9, 2026
Updates description to point to `CertificateParams`, `KeyPair`, `SigningKey` for additional explanation.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Member
Usual GitHub flakyness 🙄
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amend CertificateSigningRequest documentation to more clearly point at CertificateParams as the way to generate a new CSR with attributes.
[In the future, building one from a CSR attributes (RFC9908) object will be contributed]