ci: enable Windows tests (component runs fine; fix uppercase-hex address normalization)#185
Merged
Conversation
The component engine runs correctly on Windows — the only failure was a snapshot mismatch: CPython formats object addresses with uppercase hex on Windows (`object at 0x...B82BD0`), but the conftest normalization regex matched lowercase only (`[0-9a-f]+`), so `dcontext`'s repr address wasn't replaced with `ADDR`. Widen to `[0-9a-fA-F]+` and re-enable the windows-latest test matrix entry (disabled since Jan over presumed wasmtime WASI path issues that don't actually occur with the component backend). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component engine runs correctly on Windows — re-enabling the
windows-latesttest job (disabled since January over presumed wasmtime WASI path issues that do not occur with the component backend).Root cause of the lone failure
test_api[options]failed only because CPython formats object addresses with uppercase hex on Windows (...RLDisplayContext object at 0x...B82BD0), while the conftest normalizer matched lowercase only (r' object at 0x[0-9a-f]+>') — sodcontext's repr address wasn't replaced withADDR. Every other field (includingfilename/includepaths) matched identically.Fix
[0-9a-fA-F]+(platform-independent).windows-latest(py 3.13) matrix entry.Verified: full
test-pymatrix incl. windows-latest is green on this branch.