Skip to content

fix(ci): pass GITHUB_TOKEN to build to avoid GitHub API rate limits - #92

Open
majinghe wants to merge 1 commit into
rustfs:mainfrom
majinghe:fix/deploy-github-token
Open

fix(ci): pass GITHUB_TOKEN to build to avoid GitHub API rate limits#92
majinghe wants to merge 1 commit into
rustfs:mainfrom
majinghe:fix/deploy-github-token

Conversation

@majinghe

Copy link
Copy Markdown
Contributor

Why

After #91, the production download page is built with the new Script/DEB/RPM tabs, but the DEB/RPM tabs and release info are missing on the live site.

The root cause: the deploy workflow runs pnpm run build without a GitHub token, so the build's getLatestRelease() call hits the GitHub API anonymously. When the anonymous rate limit is exhausted, the release resolves to null and the release-dependent UI (DEB/RPM tabs, release panel, package buttons) is intentionally hidden.

Fix

Pass the workflow's built-in github.token to the build step in deploy.yml, so release fetching is authenticated and no longer shares the anonymous 60 requests/hour limit.

Verification

  • With a token present, the build resolves the latest release and the download page renders the Script/DEB/RPM tabs and DEB/RPM packages (verified locally).
  • This is a CI-only change; no runtime code is affected.

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@majinghe is attempting to deploy a commit to the overtrue's projects Team on Vercel.

A member of the Team first needs to authorize it.

@majinghe
majinghe requested a review from overtrue August 12, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant