fix: consolidate S3 Tables refresh controls - #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
S3 Tables displayed two Refresh buttons with overlapping scopes. Keep the page-header Refresh as the single normal refresh action and remove the warehouse toolbar duplicate. Context-specific Retry actions remain available.
Continue refreshing known buckets when listing S3 buckets fails, while retaining the listing error. This preserves the ability to update the current catalog after removing the independent warehouse refresh action.
Type of Change
Testing
Browser checks against the local Next.js app with intercepted API responses verified:
No live backend data was modified. A production build was not run locally; type checking and the running page cover this bounded change, and CI runs the production build.
Checklist
Related Issues
N/A
Screenshots (if applicable)
Captured from the actual local page with illustrative fixture data. Before and after use the same viewport and catalog state; these screenshots do not represent live-backend validation.
Additional Notes
Independent correctness, simplicity, and UX review completed. The only additional requests occur when a bucket-list refresh fails after buckets were previously loaded: their statuses are still queried, with existing permission and error handling intact.