Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Automation run: rustfs/cli test gap detection.
Background
The noun-first
rc object ...command group was added to make object workflows easier to discover, but the parser coverage onorigin/mainonly exercised the bucket CORS path. That left several object subcommand delegations untested, so regressions in option wiring could silently break expected object commands.Root cause
The object command group delegates to existing command argument structs, but there were no parser tests proving that the noun-first routes preserve important flags and positional arguments for copy, move, show, head, find, and tree.
Solution
Added focused parser tests for
rc object copy,rc object move,rc object show,rc object head,rc object find, andrc object tree. The tests assert that representative positional arguments and options land in the expected delegated command variants. I also added a minimalmake pre-committarget that runs the repository's documented formatting, clippy, and test checks so the automation-required validation command is available.Validation
cargo test -p rustfs-cli cli_accepts_object_make pre-commit