test(cors): reject object paths for bucket cors#135
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes a small test gap in the new bucket CORS path handling. The CORS commands are documented and implemented as bucket-level operations, so object-style targets such as local/my-bucket/object.txt should be rejected before any network operation is attempted.
The previous parser only split the path into alias and the remaining string, then trimmed trailing slashes. That meant local/my-bucket/object.txt was accepted as a bucket name containing a slash, which could lead users toward confusing downstream S3 errors instead of a direct usage error.
The fix keeps trailing slash support for local/my-bucket/ but rejects bucket targets that still contain a slash after normalization. The focused unit test covers this rejected object-path case alongside the existing invalid CORS bucket path cases.
Validation