Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Automated test-gap detection for recent CLI structured-error changes.
Background and user impact
The cp command now emits structured JSON usage errors for local validation failures. The local-to-local copy path does not need S3, so it is a good candidate for a small regression test that proves users get machine-readable error metadata when they request JSON output.
Root cause
Existing tests covered cp parsing helpers and output serialization, but did not exercise the CLI binary path where two local filesystem paths are rejected under --json. That left the stderr JSON shape, exit code, error type, retryability flag, and custom suggestion unverified.
Solution
Added a focused error contract test that creates two temporary local files, runs rc cp source target --json, and asserts the command exits with usage code 2 while emitting the expected structured JSON error on stderr and no stdout.
Validation