Implement safe wrapper for nvmlDeviceGetGpuFabricInfoV. - #142
Open
mattnappo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a safe wrapper over
nvmlReturn_t nvmlDeviceGetGpuFabricInfoV ( nvmlDevice_t device, nvmlGpuFabricInfoV_t* gpuFabricInfo )by invoking the FFI binding provided bynvml-wrapper-sysin a similar way as the rest of this crate's wrappers.This returns a Rust struct corresponding to
nvmlGpuFabricInfo_v3_t:One limitation is that the
nvml-wrapper-syscrate does not contain bindings for the following health variants:This can be addressed in follow up work. See
nvml-wrapper/nvml-wrapper-sys/src/bindings.rs
Line 468 in eb47417
The older
nvmlReturn_t nvmlDeviceGetGpuFabricInfo ( nvmlDevice_t device, nvmlGpuFabricInfo_t* gpuFabricInfo )does not provide thehealthSummaryfield, so I do not implement it here (see nvmlGpuFabricInfo_t).Note that the output of
GpuFabricInfo::registration_resultis only worth reading whenGpuFabricStateisCompleted. Registering a device with the NVLink fabric is async, andstatusis only reported when registration/initialization completes.From the Nvidia docs:
On single-node 8xB300 systems,
nvidia-smireports the following when a device's NVLink is healthy:This can now be represented in Rust like so:
During fabric-manager initialization,
nvidia-smireports the following:Machines stuck in this
in progressstate may have underlying NVLink health issues.