intrinsic-test: simplify architecture constants#2172
Merged
davidtwco merged 1 commit intoJun 21, 2026
Conversation
davidtwco
force-pushed
the
intrinsic-test-simplify-consts
branch
from
0c09685 to
701302a
Compare
23 tasks
sayantn
approved these changes
Jun 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
This comment has been minimized.
This comment has been minimized.
There doesn't need to be so many or other modules with the values.
davidtwco
force-pushed
the
intrinsic-test-simplify-consts
branch
from
701302a to
5eef142
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #2160. This also isn't a strictly necessary refactoring, but makes the code slightly cleaner in my view by putting more of the architecture-specific details in fewer modules. It also jives well with #2170.
r? @sayantn