test(dist/manifest): use the reordered fixture in manifest_serialized_with_sorted_keys#4822
Merged
rami3l merged 1 commit intorust-lang:mainfrom Apr 21, 2026
Merged
test(dist/manifest): use the reordered fixture in manifest_serialized_with_sorted_keys#4822rami3l merged 1 commit intorust-lang:mainfrom
manifest_serialized_with_sorted_keys#4822rami3l merged 1 commit intorust-lang:mainfrom
Conversation
…d_with_sorted_keys`
rami3l
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression test for #4715 was meant to parse two TOML manifests with packages declared in different orders and assert that their serialized forms are identical, proving keys are emitted in deterministic (sorted) order. However,
EXAMPLE_REORDEREDwasinclude_str!-ing the same file asEXAMPLE, so the assertion held trivially and the test never actually exercised the sort-on-serialize behavior.This PR points it at the existing
channel-rust-nightly-example-reordered.tomlfixture so the test can catch any future regression that breaks deterministic manifest serialization.