Add rustfilt-like implementation - #95
Open
Mark-Simulacrum wants to merge 1 commit into
Open
Conversation
This is a much simpler implementation (no argument handling etc) but suffices for ~all of my use cases and is ~2x faster (due to the demangle_stream usage, which has landed upstream but hasn't been released).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially trivial (no argument handling etc) but it would be enough for ~all of my use cases and is ~2x faster than published
rustfiltdue to the demangle_stream usage, which has landed upstream but hasn't been released.@luser, would you be up for moving ownership of rustfilt on crates.io into my / T-compiler hands? I think if so, then it would make more sense to have a clean-room implementation of it (or re-license under MIT OR Apache), and then publish under that name.
If we don't hear back my suggestion is to move forward with this --
rustfilthas a few more features, e.g., support for file paths,--hashes, and demangling arguments rather than only stdin/stdout, but in my experience the implementation here is very often sufficient. This is basically zero effort to maintain, and we can (IMO) drop it if rustfilt is more actively maintained.