Rollup of 8 pull requests - #162550
Merged
Merged
Conversation
Co-authored-by: Amirhossein Akhlaghpoor <m9.akhlaghpoor@gmail.com> Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>
Fix msvc-specific differences in debuginfo tests As part of rust-lang#161657 Fixes ~every test that fails due to an msvc-specific problem. I tried to modify the `lldb-check` commands in-place where possible. If I couldn't, I used revisions. There is 1 very tiny visualizer bug fix that I lumped in here that affects summaries of empty arrays on msvc (`]` -> `[]`) `basic-types-globals.rs`- msvc stores globals under the `statics` category, and LLDB-with-PDB-debug-info requires that those be access by a fully qualified name (which shouldn't pose any issue for dwarf debug info, which IIRC can access via the qualified or unqualified name). I enforced the crate name through compiler flags, so even if this file moves around or is renamed, it shouldn't break. The above also applies to `no_mangle-info.rs` except, for some reason, non-msvc targets are *only* able to access the top level static through the unqualified path. I'm not 100% sure if this is an LLDB bug or not, but it's not a huge deal for us since we can just use revisions. The only test that changed behaviorally is `thread-names.rs`, which now uses a `script` command to print all threads, and then `compiletest` can pick the 2 it cares about out of that list. On windows, the spawned thread isn't thread 2, since there's typically a bunch of `ntdll.dll` threads. Even for non-windows, relying on exact thread numbers seems pretty fragile so this should help all around. After this patch, the remainder of the 22 test failures on `windows-msvc` are the `<variable has been optimized out>` issue and the variable shadowing issue. The variable shadowing is a bug on their end, but we can work around it. I need to look into the `<variable has been optimized out>` issue a bit more to see what's going on there. r? @Kobzol , @jieyouxu --- try-job: test-aarch64-msvc-1 try-job: test-x86_64-msvc-1 try-job: test-aarch64-gnu-debug try-job: test-x86_64-mingw-1 try-job: test-aarch64-apple-1
…call-args, r=WaffleLapkin mir: validate `Move` call arguments are locals or box derefs Fixes rust-lang#103362. This PR adds a MIR validation check for `Move` arguments passed to `Call` and `TailCall` terminators. A moved argument should be either a local or the contents of the `Box`. Other places can deinitialize memory that codegen does not track correctly. The check is only enabled with `-Zvalidate-mir`, using the same phase restriction as the existing `Copy` check. Added a regression test covering the invalid case.
Generalise (most) impls on `Box` Resolves the trait impl concern for rust-lang#156882; `Default` wasn't touched since changing that would be breaking, but hopefully all of this should be fine - I'll do a crater run to be sure. Certain impls that were for one reason or another Annoying to generalise (e.g. `Clone for Box<Path>`) were also untouched since I believe we can add those in the future, as they're on concrete types. r? clarfonthey
…ys, r=aapoalas normalize CoerceShared field types before relating fixes rust-lang#162144 we need to normalize the field types before passing them to NllTypeRelating since they may still contain projections from the source or target type
…trochenkov fix: fix no resolution for self import in namespaced crates closes rust-lang#160512 Add a check for `ident.name == kw::SelfLower` in `ModuleOrUniformRoot::OpenModule` branch with correct `Res`
…ait-generic-suggestion, r=petrochenkov Avoid suggesting gated generic arguments for Fn-family traits Fixes rust-lang#136407
…khyperia Don't explicitly specify `OnDuplicate::Error` as it is the default
yeet VisitorExt This existed to stop people from overriding some methods, but `final fn` exists now. It's already being used in std here and there with no problems, so I figure it's fine to use in the compiler.
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Rollup of 8 pull requests Successful merges: - #162412 (Fix msvc-specific differences in debuginfo tests) - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161946 (Generalise (most) impls on `Box`) - #162192 (normalize CoerceShared field types before relating) - #160518 (fix: fix no resolution for self import in namespaced crates) - #162509 (Avoid suggesting gated generic arguments for Fn-family traits) - #162521 (Don't explicitly specify `OnDuplicate::Error` as it is the default) - #162526 (yeet VisitorExt)
Member
Contributor
|
Tree closed for PRs with priority less than 5. |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for d0f637a failed: CI. Failed job:
|
Member
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Sep 9, 2026
Member
Author
|
@bors treeclosed- as spurious |
Member
Author
|
@bors treeclosed- |
Contributor
|
Tree is now open for merging. |
1 similar comment
Contributor
|
Tree is now open for merging. |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 32ffad3 (parent) -> a36d05e (this PR) Test differencesShow 279 test diffsStage 1
Stage 2
(and 137 additional test diffs) Additionally, 42 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a36d05efab632d1ddf902b6a5c33b6d5d3b64131 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (a36d05e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 0.4%, secondary -3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 481.963s -> 481.833s (-0.03%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 32ffad32f4 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Successful merges:
Movecall arguments are locals or box derefs #160651 (mir: validateMovecall arguments are locals or box derefs)Box#161946 (Generalise (most) impls onBox)OnDuplicate::Erroras it is the default #162521 (Don't explicitly specifyOnDuplicate::Erroras it is the default)r? @ghost
Create a similar rollup