Rollup of 14 pull requests - #162333
Merged
Merged
Conversation
This updates the rust-version file to 0f33d09.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@0f33d09 Filtered ref: rust-lang/miri@d755e9c Upstream diff: rust-lang/rust@9bb55c8...0f33d09 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
This updates the rust-version file to d9dd070.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@d9dd070 Filtered ref: rust-lang/miri@22d0f58 Upstream diff: rust-lang/rust@0f33d09...d9dd070 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
This updates the rust-version file to d0f2ef5.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@d0f2ef5 Filtered ref: rust-lang/miri@cab8e1d Upstream diff: rust-lang/rust@d9dd070...d0f2ef5 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
add chacha20 target feature bug to trophy case
Installing cargo tools (`cargo install`) without locked dependencies exposes users to supply-chain attacks to all the dependencies of the tool (https://blog.rust-lang.org/2026/08/20/supply-chain-attack-on-arrayref/). Using `cargo install --locked` reduces this risk to a compromise of the tool itself, while using the locked and hashed version of the dependencies. I went through all `rg "cargo install"` hits in the repository and added `--locked` to all but explanatory examples (such as cargo's docs on `cargo install` itself). I validated that those tools publish functioning `Cargo.lock`s with https://gist.github.com/konstin/bcb1169c1c1120c259dca64e777a64d0.
This updates the rust-version file to 17fd5b8.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@17fd5b8 Filtered ref: rust-lang/miri@e69d469 Upstream diff: rust-lang/rust@d0f2ef5...17fd5b8 This merge was created using https://github.com/rust-lang/josh-sync.
…ocked Install cargo tools with locked dependencies
Remove outdated reference to -Zsaturating-float-casts
use `portable_simd` vector types for `f16` tests
This updates the rust-version file to edc52f8.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@edc52f8 Filtered ref: rust-lang/miri@4c181b9 Upstream diff: rust-lang/rust@17fd5b8...edc52f8 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
This updates the rust-version file to 2e2b193.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@2e2b193 Filtered ref: rust-lang/miri@fa4559e Upstream diff: rust-lang/rust@edc52f8...2e2b193 This merge was created using https://github.com/rust-lang/josh-sync.
rustbot
added
O-SGX
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Sep 5, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 546f07f (parent) -> f207aa3 (this PR) Test differencesShow 664 test diffsStage 1
Stage 2
(and 521 additional test diffs) Additionally, 43 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard f207aa3913114c3326bc0b88acbd12b10244edf8 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (f207aa3): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.0%, secondary -0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeResults (primary -0.2%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 478.607s -> 476.209s (-0.50%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 546f07f6ee In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Member
Author
Collaborator
Running triage with 32 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#158312 778219a Adds support for AArch64 SVE to inline assemblyInstruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -1.9%, secondary -0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeResults (primary 0.0%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
#160745 bb0edf2 make closures act like MaybeDanglingInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.9%, secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.2%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
#161263 987753a break rustc_expand-rustc_middle dependencyInstruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -2.1%, secondary 6.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 3.1%, secondary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
#161616 bee0ce4 Report precondition violation for
|
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
5.7% | [5.7%, 5.7%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-6.4% | [-6.4%, -6.4%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
Results (primary 0.0%, secondary 0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
0.0% | [0.0%, 0.1%] | 11 |
| Regressions ❌ (secondary) |
0.1% | [0.1%, 0.1%] | 3 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 0.0% | [0.0%, 0.1%] | 11 |
#162250 6f0ae4f Fix hashing of span end columns in incremental compilation
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.3% | [0.2%, 0.3%] | 5 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results (secondary 6.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
6.6% | [6.6%, 6.6%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
Results (primary 2.5%, secondary 3.4%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
2.5% | [2.5%, 2.5%] | 1 |
| Regressions ❌ (secondary) |
3.4% | [3.4%, 3.4%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 2.5% | [2.5%, 2.5%] | 1 |
Binary size
Results (primary 0.0%, secondary 0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
0.0% | [0.0%, 0.1%] | 11 |
| Regressions ❌ (secondary) |
0.1% | [0.1%, 0.1%] | 3 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 0.0% | [0.0%, 0.1%] | 11 |
Member
rustbot
added
the
perf-regression-triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
wasm32-wasip3to a tier 2 target #161940 (Promotewasm32-wasip3to a tier 2 target)<usize as SliceIndex>::get_uncheckedin const-eval #161616 (Report precondition violation for<usize as SliceIndex>::get_uncheckedin const-eval)./x doc compiler/rustc --open#162318 (bootstrap: Fix broken path for./x doc compiler/rustc --open)r? @ghost
Create a similar rollup