Skip to content

move bug and span_bug macros to rustc_span - #161873

Open
mejrs wants to merge 6 commits into
rust-lang:mainfrom
mejrs:bug
Open

move bug and span_bug macros to rustc_span#161873
mejrs wants to merge 6 commits into
rust-lang:mainfrom
mejrs:bug

Conversation

@mejrs

@mejrs mejrs commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

View all comments

This allows them to be used without depending on rustc_middle.

This is done by using a rustc_interface callback so that, if the callback is set, a internal compiler error diagnostic is printed through that. After that the panic is initiated.

r? @jdonszelmann @bjorn3

@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

changes to the core type system

cc @lcnr

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in coverage instrumentation.

cc @Zalathar

changes to the core type system

cc @lcnr

Some changes occurred in compiler/rustc_codegen_llvm/src/llvm/enzyme_ffi.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in match lowering

cc @Nadrieril

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Aug 27, 2026
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2026
@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@GuillaumeGomez

GuillaumeGomez commented Aug 27, 2026

Copy link
Copy Markdown
Member

Neat. :)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
bjorn3
bjorn3 reviewed Aug 27, 2026
View reviewed changes
Comment thread compiler/rustc_span/src/macros.rs Outdated
@bjorn3 bjorn3 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2026
@mejrs mejrs mentioned this pull request Aug 27, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 28, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161891 - mejrs:eii_incomplete, r=RalfJung
b655944 
Mark `extern_item_impls` feature as incomplete

context: rust-lang#161873 (comment)

> If they are so unstable, maybe they should have a separate feature gate that's marked as `incomplete`. Or the entire `extern_item_impls` should be marked "incomplete".

I think it's just best to mark the entire thing as incomplete for now. Later, when the implementation matures we can consider removing the incompleteness or splitting the feature in unstable and incomplete parts.

r? @bjorn3 @RalfJung
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 28, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161891 - mejrs:eii_incomplete, r=RalfJung
ef67a60 
Mark `extern_item_impls` feature as incomplete

context: rust-lang#161873 (comment)

> If they are so unstable, maybe they should have a separate feature gate that's marked as `incomplete`. Or the entire `extern_item_impls` should be marked "incomplete".

I think it's just best to mark the entire thing as incomplete for now. Later, when the implementation matures we can consider removing the incompleteness or splitting the feature in unstable and incomplete parts.

r? @bjorn3 @RalfJung
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 28, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161891 - mejrs:eii_incomplete, r=RalfJung
17366b1 
Mark `extern_item_impls` feature as incomplete

context: rust-lang#161873 (comment)

> If they are so unstable, maybe they should have a separate feature gate that's marked as `incomplete`. Or the entire `extern_item_impls` should be marked "incomplete".

I think it's just best to mark the entire thing as incomplete for now. Later, when the implementation matures we can consider removing the incompleteness or splitting the feature in unstable and incomplete parts.

r? @bjorn3 @RalfJung
rust-bors Bot pushed a commit that referenced this pull request Aug 28, 2026
@bors
Unrolled build for #161891 in rollup 161906
32b32c1 
Rollup merge of #161891 - mejrs:eii_incomplete, r=RalfJung

Mark `extern_item_impls` feature as incomplete

context: #161873 (comment)

> If they are so unstable, maybe they should have a separate feature gate that's marked as `incomplete`. Or the entire `extern_item_impls` should be marked "incomplete".

I think it's just best to mark the entire thing as incomplete for now. Later, when the implementation matures we can consider removing the incompleteness or splitting the feature in unstable and incomplete parts.

r? @bjorn3 @RalfJung
@rust-bors

This comment has been minimized.

Sign in to view
@mejrs
mejrs force-pushed the bug branch 2 times, most recently from 2b61a0e to aed9a77 Compare August 28, 2026 22:31
@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

rustc_errors::annotate_snippet_emitter_writer was changed

cc @Muscraft

@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

@rustbot

This comment has been minimized.

Sign in to view
@mejrs mejrs changed the title use eii for bug! macro move bug and span_bug macros to rustc_span Aug 28, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@Zalathar

Zalathar commented Sep 2, 2026

Copy link
Copy Markdown
Member

(By the way, if you wanted to avoid a bunch of rebase churn, you could potentially leave a public re-export in rustc_middle for this PR, and then leave the removal of that re-export to one or more follow-up PRs.)

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@mejrs

mejrs commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

(By the way, if you wanted to avoid a bunch of rebase churn, you could potentially leave a public re-export in rustc_middle for this PR, and then leave the removal of that re-export to one or more follow-up PRs.)

The merge conflicts are relatively simple to resolve (it's just imports) and in my experience it's best to just pull off the bandaid and get it over with.

That said, it would be nice if someone would review it 🙂

r? compiler

@rustbot rustbot assigned tiif and unassigned jdonszelmann Sep 6, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tiif

tiif commented Sep 9, 2026

Copy link
Copy Markdown
Member

I will only be able to review this on Saturday. If this is bitrotty, feel free to re-roll another reviewer :>

@rust-bors

rust-bors Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161957) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung left review comments
@bjorn3 bjorn3 bjorn3 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@tiif tiif

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mejrs @rustbot @GuillaumeGomez @rust-log-analyzer @Zalathar @tiif @RalfJung @bjorn3 @jdonszelmann