Only use dlltool.exe on MinGW if -Cdlltool is passed - #161050
Conversation
The linker used by MinGW now works with ar_archive_writer generated short import libraries too.
7dda195 to
fd82481
Compare
|
@rustbot ready MCP has been accepted. |
|
@bors r+ |
|
📋 This PR cannot be approved because it currently has the following label: |
|
@bors r+ I suppose we will want to include it in release notes, no? |
Only use dlltool.exe on MinGW if -Cdlltool is passed The linker used by MinGW now works with ar_archive_writer generated short import libraries too. Implements rust-lang/compiler-team#1029 r? @mati865
Only use dlltool.exe on MinGW if -Cdlltool is passed The linker used by MinGW now works with ar_archive_writer generated short import libraries too. Implements rust-lang/compiler-team#1029 r? @mati865
Only use dlltool.exe on MinGW if -Cdlltool is passed The linker used by MinGW now works with ar_archive_writer generated short import libraries too. Implements rust-lang/compiler-team#1029 r? @mati865
…uwer Rollup of 6 pull requests Successful merges: - #155499 (stabilize never type) - #161294 (add crashtests [6/N]) - #161050 (Only use dlltool.exe on MinGW if -Cdlltool is passed) - #159583 (Add new `invalid_markdown_table` rustdoc lint) - #161098 (PassWrapper: handle LLVM 24 change in function types) - #161661 (Don't treat slashes as path seps after drive letters in verbatim paths)
Only use dlltool.exe on MinGW if -Cdlltool is passed The linker used by MinGW now works with ar_archive_writer generated short import libraries too. Implements rust-lang/compiler-team#1029 r? @mati865
…uwer Rollup of 5 pull requests Successful merges: - #161294 (add crashtests [6/N]) - #161050 (Only use dlltool.exe on MinGW if -Cdlltool is passed) - #159583 (Add new `invalid_markdown_table` rustdoc lint) - #161098 (PassWrapper: handle LLVM 24 change in function types) - #161661 (Don't treat slashes as path seps after drive letters in verbatim paths)
Only use dlltool.exe on MinGW if -Cdlltool is passed The linker used by MinGW now works with ar_archive_writer generated short import libraries too. Implements rust-lang/compiler-team#1029 r? @mati865
…uwer Rollup of 6 pull requests Successful merges: - #155499 (stabilize never type) - #161294 (add crashtests [6/N]) - #161050 (Only use dlltool.exe on MinGW if -Cdlltool is passed) - #159583 (Add new `invalid_markdown_table` rustdoc lint) - #161098 (PassWrapper: handle LLVM 24 change in function types) - #161661 (Don't treat slashes as path seps after drive letters in verbatim paths)
|
@bors try jobs=dist-i686-mingw |
This comment has been minimized.
This comment has been minimized.
Only use dlltool.exe on MinGW if -Cdlltool is passed try-job: dist-i686-mingw
|
I can look into that failure tomorrow. Looks like we don't prefix import symbols correctly on i686 windows GNU for some reason. |
|
@bors r- |
|
This pull request was unapproved. This PR was contained in a rollup (#161688), which was unapproved. |
|
💔 Test for 3d9e5bb failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Okay, I couldn't resist. |
The linker used by MinGW now works with ar_archive_writer generated short import libraries too.
Implements rust-lang/compiler-team#1029
r? @mati865