Skip to content

Rollup of 20 pull requests#159802

Merged
rust-bors[bot] merged 98 commits into
rust-lang:mainfrom
jhpratt:rollup-0P0tnuA
Jul 24, 2026
Merged

Rollup of 20 pull requests#159802
rust-bors[bot] merged 98 commits into
rust-lang:mainfrom
jhpratt:rollup-0P0tnuA

Conversation

@jhpratt

@jhpratt jhpratt commented Jul 23, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

zachs18 and others added 30 commits July 7, 2026 20:53
…d ZST struct/enums.

Also add tests for the guaranteed types.
use sentence case on some section/chapter titles
Replace codeview.pdf with link to archived webpage
Clarify what to do when you break a subtree build
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 23, 2026
@jhpratt

jhpratt commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-*

@rust-bors

rust-bors Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit fad9bb7 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 23, 2026
Rollup of 20 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 0c69903 (0c699039f0af721beabb09ffeb173532dff11c6b)
Base parent: 89c61a7 (89c61a7545da48b06116675b888398d02a4064c7)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 24, 2026
@rust-bors

rust-bors Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 22m 50s
Pushing 1498f99 to main...

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 76c35a1 (parent) -> 1498f99 (this PR)

Test differences

Show 615 test diffs

Stage 1

  • [ui (polonius)] tests/ui/any/any_static.rs#next: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/any/non_static.rs#next: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/any/non_static.rs#old: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/any/try_as_dyn_assoc_ty_lifetime.rs#old: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/any/try_as_dyn_mut.rs#next: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/any/try_as_dyn_mut.rs#old: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/any/try_as_dyn_soundness_test1.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/any/try_as_dyn_soundness_test1.rs#old: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/coherence/coherence-overlap-downstream-fundamental.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/crate-loading/missing-target-error.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/debuginfo/cross-crate-multibyte-debuginfo.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/enum-discriminant/repr-u64-enum-discriminant-cast.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/functional-struct-update/fru-unknown-field-in-closure.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/issues/issue-37131.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-37510.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-37884.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-3895.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-3979.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-39848.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-3991.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-43250.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-43355.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-44216-add-instant.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-47094.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-4736.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-4759.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-50415.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/issues/issue-50618.rs: pass -> [missing] (J1)
  • [ui (polonius)] tests/ui/lifetimes/lifetime-errors/iterator-next-extra-named-lifetime.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/range/inclusive-range-in-closure.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/std/instant-sub-duration-overflow.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/traits/coerce-diverging-through-from.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/traits/default-method/nested-supertrait-method-in-default-body.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/traits/object/nested-trait-method-call.rs: [missing] -> pass (J1)
  • [ui] tests/ui/any/any_static.rs#next: [missing] -> pass (J2)
  • [ui] tests/ui/any/builtin_bound.rs#old: [missing] -> pass (J2)
  • [ui] tests/ui/any/non_static.rs#old: [missing] -> pass (J2)
  • [ui] tests/ui/any/trait_info_of.rs#next: [missing] -> pass (J2)
  • [ui] tests/ui/any/try_as_dyn.rs#next: [missing] -> pass (J2)
  • [ui] tests/ui/any/try_as_dyn_soundness_test2.rs#next: [missing] -> pass (J2)
  • [ui] tests/ui/coherence/clone-impl-unsized-slice.rs: [missing] -> pass (J2)
  • [ui] tests/ui/issues/issue-3979-2.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-39808.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-39827.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-43853.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-44216-add-system-time.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-50618.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-5067.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-52262.rs: pass -> [missing] (J2)
  • [ui] tests/ui/lowering/expr-metavar-in-let-pattern.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/repetition-matches-empty-token-tree.rs: [missing] -> pass (J2)
  • [ui] tests/ui/methods/destructure-and-call-self-method.rs: [missing] -> pass (J2)
  • [ui] tests/ui/moves/move-out-of-shared-ref-deref.rs: [missing] -> pass (J2)
  • [ui] tests/ui/pattern/struct-pattern-nonexistent-field.rs: [missing] -> pass (J2)
  • [ui] tests/ui/pattern/type-alias-as-variant-pattern.rs: [missing] -> pass (J2)
  • [ui] tests/ui/std/instant-add-duration-overflow.rs: [missing] -> pass (J2)
  • [ui] tests/ui/std/system-time-add-duration-overflow.rs: [missing] -> pass (J2)
  • [ui] tests/ui/structs/tuple-struct-init-with-named-field.rs: [missing] -> pass (J2)
  • [ui] tests/ui/traits/coerce-diverging-through-from.rs: [missing] -> pass (J2)

Stage 2

  • [ui] tests/ui/any/trait_info_of.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/any/try_as_dyn.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/any/try_as_dyn_assoc_ty_lifetime.rs#old: [missing] -> pass (J0)
  • [ui] tests/ui/any/try_as_dyn_elaborated_bounds.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/any/try_as_dyn_elaborated_bounds.rs#old: [missing] -> pass (J0)
  • [ui] tests/ui/any/try_as_dyn_mut.rs: pass -> [missing] (J0)
  • [ui] tests/ui/any/try_as_dyn_soundness_test1.rs#next: [missing] -> pass (J0)
  • [ui] tests/ui/borrowck/push-on-nested-vec.rs: [missing] -> pass (J0)
  • [ui] tests/ui/coherence/coherence-overlap-downstream-fundamental.rs: [missing] -> pass (J0)
  • [ui] tests/ui/consts/const_in_pattern/const-bytes-slice-pattern.rs: [missing] -> pass (J0)
  • [ui] tests/ui/debuginfo/cross-crate-multibyte-debuginfo.rs: [missing] -> pass (J0)
  • [ui] tests/ui/enum-discriminant/repr-u64-enum-discriminant-cast.rs: [missing] -> pass (J0)
  • [ui] tests/ui/issues/issue-3702-2.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-3702.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-37510.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-37665.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-3779.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-38942.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-38954.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-3979-2.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-39808.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-42880.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-44216-add-instant.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-48131.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-50415.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-51102.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-51907.rs: pass -> [missing] (J0)
  • [ui] tests/ui/iterators/rpit-method-chain-no-ice.rs: [missing] -> pass (J0)
  • [ui] tests/ui/macros/attr-path-metavar-generic-args.rs: [missing] -> pass (J0)
  • [ui] tests/ui/macros/repetition-matches-empty-token-tree.rs: [missing] -> pass (J0)
  • [ui] tests/ui/match/guard-arm-and-or-arm.rs: [missing] -> pass (J0)
  • [ui] tests/ui/methods/by-value-self-method-on-int.rs: [missing] -> pass (J0)
  • [ui] tests/ui/methods/destructure-and-call-self-method.rs: [missing] -> pass (J0)
  • [ui] tests/ui/mir/hoist_deref_early_else.rs#opt: [missing] -> pass (J0)
  • [ui] tests/ui/std/instant-sub-duration-overflow.rs: [missing] -> pass (J0)
  • [ui] tests/ui/structs-enums/call-tuple-struct-ctor-as-fn.rs: [missing] -> pass (J0)
  • [ui] tests/ui/structs/tuple-struct-init-with-named-field.rs: [missing] -> pass (J0)
  • [ui] tests/ui/traits/coerce-diverging-through-from.rs: [missing] -> pass (J0)
  • [ui] tests/ui/traits/default-method/nested-supertrait-method-in-default-body.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type-inference/diverging-expr-unconstrained-type-param.rs: [missing] -> pass (J0)
  • [ui] tests/ui/unsized/unsized-ref-fn-param.rs: [missing] -> pass (J0)

(and 329 additional test diffs)

Additionally, 186 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1498f9968f75e8e5ded6892b9c97bfe66b5a966f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc-core-tests: 8m 30s -> 14m 9s (+66.5%)
  2. x86_64-msvc-ext3: 1h 43m -> 1h 8m (-33.9%)
  3. x86_64-gnu-miri: 1h 29m -> 1h 2m (-30.7%)
  4. dist-armhf-linux: 1h 7m -> 1h 26m (+27.3%)
  5. x86_64-msvc-ext1: 2h 9m -> 1h 39m (-23.7%)
  6. optional-x86_64-gnu-parallel-frontend: 1h 31m -> 1h 53m (+23.6%)
  7. dist-x86_64-msvc-alt: 2h 45m -> 2h 6m (-23.3%)
  8. dist-various-1: 1h 3m -> 1h 16m (+21.1%)
  9. dist-apple-various: 2h 15m -> 1h 47m (-20.6%)
  10. dist-arm-linux-musl: 1h 18m -> 1h 33m (+19.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150161 Remove 'static requirement on try_as_dyn d7b15f62cab0f17ccb06c005628a2aa2773b912e (link)
#159412 Reorganize tests/ui/issues [26/N] f520305e38d7fccd0767db29915b0a7ce6b29266 (link)
#159466 cmse: clear variant-dependent padding in enums 3262b80b721aa16ef3ca46c7b126c93511366146 (link)
#157905 Update comments and add tests for -Zrandomize-layout for … d945b77ba105b6ce0454f46c52ae9dc96fece1f0 (link)
#158479 Reject static item as direct const generic arg dfd532fe2258acad48fe647d8dd19d25cd7c80de (link)
#159041 Reorganize tests/ui/issues [22/N] 6df96c4921d793f761fa420490e94f8fea1716bc (link)
#159108 Reorganize tests/ui/issues [23/N] a7a80041b25811c6e5e8500ad22cad3687c178a8 (link)
#159138 doc: document wasm import symbol mangling 4c3f8fd575bd640559ad8340456c315019c48887 (link)
#159531 Reorganize tests/ui/issues [28/N] 6d87b647c33320e448357019660c894c509e6f3f (link)
#159608 early_otherwise: Don't hoist dereferences when the otherwis… 3343ef22a027e314cfe2a1da7e795890a4fe7647 (link)
#159612 Reorganize tests/ui/issues [29/N] 38a06cfd4aa03faf19e4452e809a48ee051b1ca2 (link)
#159653 run tests/assembly-llvm/asm/aarch64-types.rs for `aarch64… cffc4162220035d1b5a887cf9afd00cfe725b394 (link)
#159719 tests: add UI test for .swap() suggestion 98ca038953a522b78c066690d637d9a10351c713 (link)
#159737 rustfmt fix: allow file not found errors for external mods … d9e8c40056268d3958531a654edb9496cb9204a1 (link)
#159759 rustc-dev-guide subtree update e7e52b156d6b388aacce0840f3564d60182b40c6 (link)
#159761 Remove outdated comment for resolve_vars_with_obligations 85ff95a35ebf6c7d249e47b01ba387417618a84a (link)
#159764 use minicore::simd::Simd more 2cd2b61f61aac0851aaa4fe74fa96c0cfc0f621d (link)
#159773 Remove outdated workaround for P type 386a6d29cffbde6155860a2d2f3b460eb9d5ea9a (link)
#159778 use lowest edition the test accepts 17f6c5e8b1172d6d1395475ef0e430ddbd697d07 (link)
#159788 Avoid ICEing in RPIT method chain suggestion ee65907d1d266f6d888bfa6e4ac122e69285d99d (link)

previous master: 76c35a14a4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (1498f99): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.3%] 20
Regressions ❌
(secondary)
0.4% [0.2%, 0.6%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.2%, 0.3%] 20

Max RSS (memory usage)

Results (primary -4.3%, secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.3% [-4.3%, -4.3%] 1
Improvements ✅
(secondary)
-0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) -4.3% [-4.3%, -4.3%] 1

Cycles

Results (secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.3%, 2.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.3% [-6.2%, -2.4%] 2
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.2%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.2% [0.0%, 0.4%] 65
Regressions ❌
(secondary)
0.3% [0.0%, 0.5%] 50
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.0%, 0.4%] 65

Bootstrap: 488.274s -> 486.272s (-0.41%)
Artifact size: 387.66 MiB -> 387.67 MiB (0.00%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 24, 2026
@panstromek

Copy link
Copy Markdown
Contributor

Caused by #150161

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustc-dev-guide Area: rustc-dev-guide merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.