Sync from portable simd 2026 07 20 by folkertdev · Pull Request #159582 · rust-lang/rust

folkertdev · 2026-07-19T22:10:45Z

feel free to r+ once green

the `float-cmp` and `num-traits` libraries don't (yet) support f16. Turns out we didn't really need much from them, just the ulps check. I've adapted the ulps check from miri instead

relevant for the cranelift backend, possibly other cases/targets too

Fix pointer API to match what was stabilized

We can do swizzles for 24, 32, 48 and 64 byte vectors by stacking multiple TBL instructions. See https://godbolt.org/z/PE95nrqjj for a comparison of the generated assembly.

Optimize `swizzle_dyn` for AArch64 with N > 16

`From` impls were already provided for the normal AArch64 ACLE vector types, but not for the x2,x3,x4 tuples of ACLE vectors. Rectify that. Also provide impls for vectors of `f16`, as I noticed they were missing.

For symmetry with `Mask::first_set`

Add `Mask::last_set` method

…mpls Provide `From` impls for AArch64 ACLE tuple types.

Use `impl` restrictions over hand-sealed traits

Optimize `swizzle_dyn` for LoongArch64 with N is 16 or 32

run `f16` float tests

…nelift backend

…m-portable-simd-2026-07-20

rustbot · 2026-07-19T22:10:48Z

portable-simd is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

rustbot · 2026-07-19T22:10:50Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 7d497cc
The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
- 44a03e6
- 5b7c840
- 7d497cc
- 8e3bfb0
- 94a3ba2
- a27ae1d
- b010737
- be090a7
- d7a525f
You can start a rebase with the following commands:
```
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git main
$ git push --force-with-lease
```

folkertdev · 2026-07-19T22:14:02Z

This sync (specifically ignoring f16 tests) will help with rust-lang/rustc_codegen_cranelift#1675

rustbot · 2026-07-20T10:17:43Z

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

folkertdev · 2026-07-20T13:10:40Z

Hmm, blocked on rust-lang/miri#5219 (needs to be merged and synced).

RalfJung · 2026-07-20T14:16:40Z

We can also disable that test on aarch64 for now with a FIXME, if you want to not block this sync. It's a very new test.

…port

oli-obk · 2026-07-20T16:55:26Z

@bors r+

rust-bors · 2026-07-20T16:55:29Z

📌 Commit f32f69b has been approved by oli-obk

It is now in the queue for this repository.

folkertdev · 2026-07-20T18:03:14Z

@bors p=1

@ghost

…-2026-07-20, r=oli-obk Sync from portable simd 2026 07 20 r? @ghost feel free to `r+` once green

…uwer Rollup of 7 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #157270 (ergonomic_clones_dotuse_capture_by_ref: Capture upvar by ref for `.use` in non-move closures) - #158496 (Move `check_rustc_pub_transparent` into the attribute parser) - #158547 (Move `std::io::buffered` to `alloc::io`) - #159505 (make rustdoc::bare_urls strip trailing periods from url) - #159578 (Extract coroutine closure helper functions) - #159613 (Set the rustc lib path for unstable-book-gen)

rust-bors · 2026-07-21T03:23:32Z

⌛ Testing commit f32f69b with merge 64ae15d...

Workflow: https://github.com/rust-lang/rust/actions/runs/29798410909

@ghost

…, r=oli-obk Sync from portable simd 2026 07 20 r? @ghost feel free to `r+` once green

jhpratt · 2026-07-21T03:33:01Z

yielding to hopefully include this in a rollup

@bors yield

rust-bors · 2026-07-21T03:33:04Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/29798410909

The next pull request likely to be tested is #159149.

jhpratt · 2026-07-21T03:37:14Z

maybe not; looks like the floating point tests added are failing

#159622 (comment)

failures:

---- num::floats::log::test_f16 stdout ----

thread 'num::floats::log::test_f16' (2394) panicked at library/coretests/tests/num/floats.rs:1668:9:
1.011 is not approximately equal to 1.0 (threshold 0.01, difference 0.01074)
---- num::floats::log::test_f16 stdout end ----

failures:
    num::floats::log::test_f16

test result: FAILED. 2738 passed; 1 failed; 25 ignored; 0 measured; 0 filtered out; finished in 1510.80s

@bors r-

rust-bors · 2026-07-21T03:37:20Z

This PR was contained in a rollup (#159622), which was unapproved.

View changes since this unapproval

folkertdev and others added 17 commits April 12, 2026 13:26

implement our own ulps check to test f16

eb7cb89

the `float-cmp` and `num-traits` libraries don't (yet) support f16. Turns out we didn't really need much from them, just the ulps check. I've adapted the ulps check from miri instead

disable f16 tests when not target_has_reliable_f16_math

f40da91

relevant for the cranelift backend, possibly other cases/targets too

Fix pointer API to match what was stabilized

c4f3110

Merge pull request rust-lang#526 from rust-lang/update-pointer-api

94a3ba2

Fix pointer API to match what was stabilized

Optimize swizzle_dyn for AArch64 with N > 16

beafe83

We can do swizzles for 24, 32, 48 and 64 byte vectors by stacking multiple TBL instructions. See https://godbolt.org/z/PE95nrqjj for a comparison of the generated assembly.

Merge pull request rust-lang#528 from Kmeakin/km/aarch64-dyn-swizzle

be090a7

Optimize `swizzle_dyn` for AArch64 with N > 16

Provide From impls for AArch64 ACLE tuple types.

b16ee62

`From` impls were already provided for the normal AArch64 ACLE vector types, but not for the x2,x3,x4 tuples of ACLE vectors. Rectify that. Also provide impls for vectors of `f16`, as I noticed they were missing.

Use impl restrictions over hand-sealed traits

61ae55e

Add Mask::last_set method

ae33abe

For symmetry with `Mask::first_set`

Merge pull request rust-lang#532 from Kmeakin/km/simd-last-set

a27ae1d

Add `Mask::last_set` method

Merge pull request rust-lang#530 from Kmeakin/km/aarch64-tuple-from-i…

8e3bfb0

…mpls Provide `From` impls for AArch64 ACLE tuple types.

Merge pull request rust-lang#529 from jhpratt/master

d7a525f

Use `impl` restrictions over hand-sealed traits

Optimize swizzle_dyn for LoongArch64 with N is 16 or 32

30bdfe3

Merge pull request rust-lang#533 from heiher/swizzle-dyn-loong64

44a03e6

Optimize `swizzle_dyn` for LoongArch64 with N is 16 or 32

Merge pull request rust-lang#518 from folkertdev/test-float-f16

5b7c840

run `f16` float tests

Merge of rust-lang/portable-simd#520: disable f16 tests for the cra…

7d497cc

…nelift backend

Merge commit '7d497cca160ae6062acc1a2db838667f83c0b58e' into sync-fro…

b010737

…m-portable-simd-2026-07-20

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2026

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2026

This comment has been minimized.

Sign in to view

folkertdev added 2 commits July 20, 2026 10:49

fix feature gate

e09b887

remove now-dead Sealed trait

b045903

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 20, 2026

This comment has been minimized.

Sign in to view

fix simd tests that use without_provenance{_mut}

7629861

folkertdev force-pushed the sync-from-portable-simd-2026-07-20 branch from e7ea91d to 7629861 Compare July 20, 2026 11:10

This comment has been minimized.

Sign in to view

RalfJung reviewed Jul 20, 2026

View reviewed changes

Comment thread src/tools/miri/tests/pass/intrinsics/portable-simd.rs Outdated

disable portable_simd miri test that needs additional intrinsic sup…

f32f69b

…port

folkertdev force-pushed the sync-from-portable-simd-2026-07-20 branch from 0574ce9 to f32f69b Compare July 20, 2026 16:39

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026

Rollup merge of rust-lang#159582 - folkertdev:sync-from-portable-simd…

270fbc9

…-2026-07-20, r=oli-obk Sync from portable simd 2026 07 20 r? @ghost feel free to `r+` once green

JonathanBrouwer mentioned this pull request Jul 20, 2026

Rollup of 7 pull requests #159622

Closed

rust-bors Bot pushed a commit that referenced this pull request Jul 21, 2026

Auto merge of #159582 - folkertdev:sync-from-portable-simd-2026-07-20…

64ae15d

…, r=oli-obk Sync from portable simd 2026 07 20 r? @ghost feel free to `r+` once green

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2026

Uh oh!

Uh oh!

Conversation

folkertdev commented Jul 19, 2026

Uh oh!

rustbot commented Jul 19, 2026

Uh oh!

rustbot commented Jul 19, 2026

Uh oh!

folkertdev commented Jul 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Jul 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

folkertdev commented Jul 20, 2026

Uh oh!

RalfJung commented Jul 20, 2026

Uh oh!

Uh oh!

oli-obk commented Jul 20, 2026

Uh oh!

rust-bors Bot commented Jul 20, 2026

Uh oh!

folkertdev commented Jul 20, 2026

Uh oh!

rust-bors Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jul 21, 2026

Uh oh!

rust-bors Bot commented Jul 21, 2026

Uh oh!

jhpratt commented Jul 21, 2026

Uh oh!

rust-bors Bot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

rust-bors Bot commented Jul 21, 2026 •

edited

Loading