[compiletest] Differentiate between LLVM LLDB and Apple LLDB#159215
Merged
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
jieyouxu
reviewed
Jul 13, 2026
This comment has been minimized.
This comment has been minimized.
Member
|
Later we can add some small command to auto-bump those versions across all debugger files, lol. Though Find + replace will also do, I guess. Thanks, this looks like it should unblock checking for LLDB on CI. |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jieyouxu
reviewed
Jul 17, 2026
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Was this PR waiting on anything else? |
Member
|
No, I just forgot to look at this again, sorry |
jieyouxu
approved these changes
Jul 19, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 19, 2026
…uwer Rollup of 6 pull requests Successful merges: - #159524 (Gather PGO profiles in parallel) - #158850 (Avoid underflow for splatted rust-call receivers) - #159215 ([compiletest] Differentiate between LLVM LLDB and Apple LLDB) - #159347 (Document rustc_public lib.rs and update README) - #159469 (Reorganize `tests/ui/issues` [27/N]) - #159512 (Add regression tests for fixed dead-code issues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch causes
compiletestto treat LLVM and Apple LLDB versions uniquely, including modifiedmin-versiondirectives. We'll need this level of granularity going forward:lldb-reprcommand fortests/debuginfo#158298 requires LLVM LLDB22.1.x. Currently,compiletestonly cares about major versions.Any tests that specified
min-lldb-versionhave been updated to equivalentmin-apple-lldb-versionandmin-llvm-lldb-versiondirectives to preserve existing test filters.r? @Kobzol, @jieyouxu