First steps of late-bound turbofishing (place FnDef behind a dummy binder)

[addiesh]

View all comments

r? oli-obk

This PR is part of #156581. This should be functionally identical to prior behavior, with the added fact that FnDef now places its arguments behind a binder.

most changes boil down to

• replacing args from FnDef with args.no_bound_vars().unwrap()
• replacing Ty::new_fn_def(/* ... */, args) with Ty::new_fn_def(/* ... */, ty::Binder::dummy(args))

[rustbot]

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[addiesh]

this change has nothing to do with LLVM and as such should probably not have A-LLVM

View changes since the review

[addiesh]

this PR probably shouldn't have as many tags as it does (A-LLVM, PG-exploit-mitigations, T-clippy, WG-trait-system-refactor)

[addiesh]

@rustbot review

[rustbot]

boxyUwU is currently at their maximum review capacity.
They may take a while to respond.

[rustbot]

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

[rustbot]

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to constck

cc @fee1-dead

changes to the core type system

cc @lcnr

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

Some changes occurred in match checking

cc @Nadrieril

HIR ty lowering was modified

cc @fmease

Some changes occurred in match lowering

cc @Nadrieril

[BoxyUwU]

cool :3 very nice step

[BoxyUwU]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[addiesh]

ok, clippy changes reverted, should be good to go!
@rustbot ready

[oli-obk]

pls squash the commits after addressing the feedback

View changes since this review

[addiesh]

i think that should do it?
@rustbot ready

[oli-obk]

Needs a rebase

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[oli-obk]

And a properly named commit message 😅