Skip to content

codegen_ssa: multiply scalable vec size by vscale#158253

Open
davidtwco wants to merge 1 commit into
rust-lang:mainfrom
davidtwco:scalable-vector-memcpy-vscale
Open

codegen_ssa: multiply scalable vec size by vscale#158253
davidtwco wants to merge 1 commit into
rust-lang:mainfrom
davidtwco:scalable-vector-memcpy-vscale

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Part of rust-lang/stdarch#2160. When emitting a memcpy for a scalable vector, the size computed by rustc (num_vectors * element_count * element_ty), since #157915, needs to be multiplied by vscale.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2026
@rustbot

rustbot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment was marked as resolved.

When emitting a `memcpy` for a scalable vector, the size computed by
rustc (`num_vectors * element_count * element_ty`), since
rust-lang#157915, needs to be multiplied by `vscale`.
@davidtwco davidtwco force-pushed the scalable-vector-memcpy-vscale branch from 90c76ec to cfc4211 Compare June 22, 2026 15:06
@rustbot

rustbot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

@rustbot

rustbot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants