sanitizers: Implement support for the sanitize ignorelist - #157808
Open
1c3t3a wants to merge 4 commits into
Open
sanitizers: Implement support for the sanitize ignorelist#1578081c3t3a wants to merge 4 commits into
1c3t3a wants to merge 4 commits into
Conversation
Collaborator
|
Some changes occurred in tests/codegen-llvm/sanitizer cc @rcvalle |
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
1c3t3a
force-pushed
the
sanitizer-ignorelist
branch
from
June 12, 2026 12:24
739335b to
624834b
Compare
The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here: https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.
1c3t3a
force-pushed
the
sanitizer-ignorelist
branch
from
June 12, 2026 12:49
624834b to
693e22f
Compare
rcvalle
reviewed
Jun 12, 2026
rcvalle
reviewed
Jun 12, 2026
rcvalle
reviewed
Jun 12, 2026
rcvalle
requested changes
Jun 12, 2026
rustbot
added
S-waiting-on-author
rustbot
added
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #158593) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
rcvalle
requested changes
Jul 28, 2026
| } | ||
| } | ||
|
|
||
| pub(crate) fn type_name_for_ignore_list<'tcx>( |
Member
There was a problem hiding this comment.
Can this be moved to the rustc_sanitizers crate? Maybe an ignorelist module there? Are there any other things that could be moved there?
| @@ -0,0 +1,22 @@ | |||
| //@ needs-sanitizer-cfi | |||
Member
There was a problem hiding this comment.
Can we move these tests to sanitizer/ignorelist/?
| RustString::build_byte_buffer(f) | ||
| } | ||
|
|
||
| pub(crate) struct SanitizerIgnoreList { |
Member
There was a problem hiding this comment.
Can this be moved to the rustc_sanitizers crate? Maybe an ignorelist module there? Are there any other things that could be moved there?
| } else { | ||
| // Do not set sanitizer attributes for naked functions. | ||
| to_add.extend(sanitize_attrs(cx, tcx, codegen_fn_attrs.sanitizers)); | ||
| let mut enabled = tcx.sess.sanitizers() - codegen_fn_attrs.sanitizers.disabled; |
Member
There was a problem hiding this comment.
Should this (or parts of this) made into a function and moved to the rustc_sanitizers crate? Maybe an ignorelist module there? Are there any other things that could be moved there?
rustbot
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.
r? @rcvalle