Skip to content

rustc_target: Use +spe for powerpcspe targets#157137

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
taiki-e:powerpcspe
Jun 2, 2026
Merged

rustc_target: Use +spe for powerpcspe targets#157137
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
taiki-e:powerpcspe

Conversation

@taiki-e
Copy link
Copy Markdown
Member

@taiki-e taiki-e commented May 30, 2026 •
edited
Loading

LLVM does not infer this from the target name and abi: "spe" is just for cfg. To actually generate the correct instructions for these targets (without -C target-cpu), we need to pass +spe to LLVM.

Fixes #138960
See also #157085
Related #137860

cc @RalfJung
cc @BKPepe (powerpc-unknown-linux-muslspe target maintainer)
cc @glaubitz (who added powerpc-unknown-linux-gnuspe in #48484)
cc @biabbas @hax0kartik (*-wrs-vxworks target maintainers)

@rustbot label +O-PowerPC +A-target-feature

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 30, 2026
@taiki-e taiki-e mentioned this pull request May 30, 2026
Open
@rustbot rustbot added A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-PowerPC Target: PowerPC processors labels May 30, 2026
@taiki-e taiki-e marked this pull request as ready for review May 30, 2026 03:32
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 30, 2026

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 30, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 30, 2026

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@rustbot

This comment has been minimized.

Sign in to view
hax0kartik
hax0kartik reviewed May 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hax0kartik hax0kartik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please give me some time to test this out for VxWorks(its Sat here, so 2-3 days)

View changes since this review

@mu001999
Copy link
Copy Markdown
Member

mu001999 commented May 30, 2026

Waiting for the test for VxWorks

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 30, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@taiki-e taiki-e mentioned this pull request May 30, 2026
Draft
@glaubitz
Copy link
Copy Markdown
Contributor

glaubitz commented May 30, 2026

Interesting, I thought what the spec file is currently doing would be enough to enable SPE support by passing -mspe and telling LLVM to use the powerpc-unknown-linux-gnuspe target.

Thanks for fixing this!

@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented May 30, 2026 •
edited
Loading

@glaubitz it only passes -mspe to the linker, which does nothing for LLVM codegen.
And apparently the LLVM target name on its own does nothing.

@glaubitz
Copy link
Copy Markdown
Contributor

glaubitz commented May 30, 2026

@glaubitz it only passes -mspe to the linker, which does nothing for LLVM codegen. And apparently the LLVM target name on its own does nothing.

Yeah, makes sense. Good catch in any case!

@hax0kartik
Copy link
Copy Markdown
Contributor

hax0kartik commented Jun 2, 2026

Thanks for waiting, i can confirm that this works on VxWorks.

@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Jun 2, 2026

Thanks for testing. :)
@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 2, 2026

📋 This PR cannot be approved because it currently has the following label: S-blocked.

@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Jun 2, 2026

@rustbot ready
@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 2, 2026

📋 This PR cannot be approved because it currently has the following label: S-blocked.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 2, 2026
@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Jun 2, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 2, 2026

📌 Commit 3277a9c has been approved by RalfJung

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 2, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of #157329 - JonathanBrouwer:rollup-DyoIgRF, r=JonathanBro…
71fe9bf 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #157035 (`LivenessValues`: use dedicated enum rather than mutually exclusive `Option`s)
 - #157182 (Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize)
 - #157310 (rustdoc: Render `impl` restriction)
 - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros)
 - #157137 (rustc_target: Use +spe for powerpcspe targets)
 - #157215 (Implement argument-dependent target checking for the `#[repr]` parser)
 - #157235 (additional changes for issue-144595)
 - #157321 (Remove unnecessary arm in `handle_res`)
 - #157324 (Add test for undefined EII static error)
rust-bors Bot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of #157329 - JonathanBrouwer:rollup-DyoIgRF, r=JonathanBro…
8be9415 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #157035 (`LivenessValues`: use dedicated enum rather than mutually exclusive `Option`s)
 - #157182 (Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize)
 - #157310 (rustdoc: Render `impl` restriction)
 - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros)
 - #157137 (rustc_target: Use +spe for powerpcspe targets)
 - #157215 (Implement argument-dependent target checking for the `#[repr]` parser)
 - #157235 (additional changes for issue-144595)
 - #157321 (Remove unnecessary arm in `handle_res`)
 - #157324 (Add test for undefined EII static error)
rust-bors Bot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of #157329 - JonathanBrouwer:rollup-DyoIgRF, r=JonathanBro…
d595fce 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #157035 (`LivenessValues`: use dedicated enum rather than mutually exclusive `Option`s)
 - #157182 (Restore simpler Encode/Decode impls for u32 and (on 64bit systems) usize)
 - #157310 (rustdoc: Render `impl` restriction)
 - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros)
 - #157137 (rustc_target: Use +spe for powerpcspe targets)
 - #157215 (Implement argument-dependent target checking for the `#[repr]` parser)
 - #157235 (additional changes for issue-144595)
 - #157321 (Remove unnecessary arm in `handle_res`)
 - #157324 (Add test for undefined EII static error)
@rust-bors rust-bors Bot merged commit 25a125d into rust-lang:main Jun 2, 2026
12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 2, 2026
rust-timer added a commit that referenced this pull request Jun 2, 2026
@rust-timer
Unrolled build for #157137
5f28fc5 
Rollup merge of #157137 - taiki-e:powerpcspe, r=RalfJung

rustc_target: Use +spe for powerpcspe targets

LLVM does not infer this from the target name and `abi: "spe"` is just for cfg.  To actually generate the correct instructions for these targets (without `-C target-cpu`), we need to pass `+spe` to LLVM.

Fixes #138960
See also #157085
Related #137860

cc @RalfJung
cc @BKPepe ([powerpc-unknown-linux-muslspe target maintainer](https://doc.rust-lang.org/nightly/rustc/platform-support/powerpc-unknown-linux-muslspe.html#target-maintainers))
cc @glaubitz (who added powerpc-unknown-linux-gnuspe in #48484)
cc @biabbas @hax0kartik ([*-wrs-vxworks target maintainers](https://doc.rust-lang.org/nightly/rustc/platform-support/vxworks.html#target-maintainers))

@rustbot label +O-PowerPC +A-target-feature
@taiki-e taiki-e deleted the powerpcspe branch June 3, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hax0kartik hax0kartik hax0kartik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mu001999 mu001999

Labels

A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-PowerPC Target: PowerPC processors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

PowerPC SPE targets don't have spe target feature enabled

6 participants

@taiki-e @rustbot @mu001999 @glaubitz @RalfJung @hax0kartik