bootstrap: add bootstrap step to run stdarch-gen checks in CI by xonx4l · Pull Request #156674 · rust-lang/rust

xonx4l · 2026-05-17T18:22:18Z

This PR ports stdarch-gen checks into the bootstrap test runner as a step, so that we can run the stdarch-gen checks via x.py test.

Changes -:
-> Adds a new StdarchGenCheck bootstrap step.
-> Mirrors https://github.com/rust-lang/stdarch/blob/f71ac102d30d5d1957277cbffc6ba631b67bffd1/.github/workflows/main.yml#L309-L333 (check-stdarch-gen job)
-> stdarch-gen-arm uses a nightly only feature (#![feature(pattern)]) but bootstrap's cargo runs on the beta toolchain thus we set RUSTC_BOOTSTRAP=1 on the child process so it builds.
-> The generators call out to rustfmt to format their output so rustfmt needs to be on PATH. So added bootstrap's rustfmt to PATH before each run. If rustfmt isn't available, the step fails early and tells the user to set rustfmt = true in bootstrap.toml .

r? @Kobzol

rustbot · 2026-05-17T18:22:24Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2026-05-26T13:35:15Z

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

Kobzol

Thank you! I left some comments, the most important one is the question about why things are copied over.

View changes since this review

rustbot · 2026-08-13T19:31:42Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Kobzol · 2026-08-14T14:17:42Z

@bors try jobs=x86_64-gnu

bootstrap: add bootstrap step to run stdarch-gen checks in CI try-job: x86_64-gnu

rust-bors · 2026-08-14T16:10:42Z

💔 Test for bb3dc02 failed: CI. Failed job:

try - x86_64-gnu (web logs, enhanced plaintext logs)

Kobzol · 2026-08-15T19:05:42Z

@bors try jobs=x86_64-gnu

bootstrap: add bootstrap step to run stdarch-gen checks in CI try-job: x86_64-gnu

rust-bors · 2026-08-15T21:37:08Z

☀️ Try build successful (CI)
Build commit: 397f471 (397f471d92c294d6660a9fc4392f5a6fa1cef566)
Base parent: b4116af (b4116af55fbe359273e2af9e5846a334606d9d6d)

Kobzol

Thank you! Left one more comment, otherwise LGTM.

@bors delegate

View changes since this review

Kobzol · 2026-08-16T08:08:22Z

    }
 }

+#[derive(Debug, Clone, PartialEq, Eq, Hash)]


Could you please add a comment on top of this struct, to briefly explain what these tests do? Thanks!

rust-bors · 2026-08-16T08:08:36Z

✌️ @xonx4l, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, then please make that change and post @bors r=Kobzol.

View changes since this delegation.

xonx4l · 2026-08-16T12:06:22Z

@bors r=Kobzol

rust-bors · 2026-08-16T12:06:24Z

📌 Commit b2e0185 has been approved by Kobzol

It is now in the queue for this repository.

@Kobzol

bootstrap: add bootstrap step to run stdarch-gen checks in CI This PR ports stdarch-gen checks into the bootstrap test runner as a step, so that we can run the stdarch-gen checks via x.py test. Changes -: -> Adds a new `StdarchGenCheck` bootstrap step. -> Mirrors `https://github.com/rust-lang/stdarch/blob/f71ac102d30d5d1957277cbffc6ba631b67bffd1/.github/workflows/main.yml#L309-L333` (check-stdarch-gen job) -> `stdarch-gen-arm` uses a nightly only feature (`#![feature(pattern)]`) but bootstrap's cargo runs on the beta toolchain thus we set `RUSTC_BOOTSTRAP=1` on the child process so it builds. -> The generators call out to `rustfmt` to format their output so `rustfmt` needs to be on `PATH`. So added bootstrap's rustfmt to `PATH` before each run. If rustfmt isn't available, the step fails early and tells the user to set `rustfmt = true` in `bootstrap.toml` . r? @Kobzol

Rollup of 12 pull requests Successful merges: - #160529 (Upgrade and deduplicate dependencies) - #161017 (Library: enforce clippy deref lints in CI) - #156674 (bootstrap: add bootstrap step to run stdarch-gen checks in CI) - #161006 ([CI] Build newer `binutils` before building `gcc`) - #161141 (Add documentation for BPF targets) - #161157 (bootstrap: Move several items out of the crate root) - #161053 (Add regression test for borrow of array drop type in const) - #161073 (Add regression test for path printing with infinitely many visible names) - #161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation) - #161146 (Switch to c8a EC2 runner for auto merges) - #161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore)) - #161150 (add crashtests [4/N])

@Kobzol

bootstrap: add bootstrap step to run stdarch-gen checks in CI This PR ports stdarch-gen checks into the bootstrap test runner as a step, so that we can run the stdarch-gen checks via x.py test. Changes -: -> Adds a new `StdarchGenCheck` bootstrap step. -> Mirrors `https://github.com/rust-lang/stdarch/blob/f71ac102d30d5d1957277cbffc6ba631b67bffd1/.github/workflows/main.yml#L309-L333` (check-stdarch-gen job) -> `stdarch-gen-arm` uses a nightly only feature (`#![feature(pattern)]`) but bootstrap's cargo runs on the beta toolchain thus we set `RUSTC_BOOTSTRAP=1` on the child process so it builds. -> The generators call out to `rustfmt` to format their output so `rustfmt` needs to be on `PATH`. So added bootstrap's rustfmt to `PATH` before each run. If rustfmt isn't available, the step fails early and tells the user to set `rustfmt = true` in `bootstrap.toml` . r? @Kobzol

…uwer Rollup of 12 pull requests Successful merges: - #160529 (Upgrade and deduplicate dependencies) - #161017 (Library: enforce clippy deref lints in CI) - #156674 (bootstrap: add bootstrap step to run stdarch-gen checks in CI) - #161006 ([CI] Build newer `binutils` before building `gcc`) - #161141 (Add documentation for BPF targets) - #161157 (bootstrap: Move several items out of the crate root) - #161053 (Add regression test for borrow of array drop type in const) - #161073 (Add regression test for path printing with infinitely many visible names) - #161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation) - #161103 (cleanup: rip out unnecessary `iter().last()` and `iter().next()`) - #161146 (Switch to c8a EC2 runner for auto merges) - #161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore))

JonathanBrouwer · 2026-08-16T17:46:00Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #161179 (comment)

rust-bors · 2026-08-16T17:46:06Z

This pull request was unapproved.

This PR was contained in a rollup (#161179), which was unapproved.

View changes since this unapproval

Kobzol · 2026-08-16T18:11:25Z

Hmm, I wonder if we should only do the check on Linux. It would be nice to improve the error message to show the actual diff of what changed, rather than saying that the diff is not clean.

Could you please check what is different there?

rustbot assigned Kobzol May 17, 2026

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 17, 2026

This comment has been minimized.

Sign in to view

Kobzol reviewed May 27, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

xonx4l added 5 commits August 13, 2026 11:09

port stdarch-gen checks into bootstrap

b20f425

use helpers::git

34cf67c

fix: set CARGO_TARGET_DIR for read-only CI

55e715d

fix: redirect generator output to a writable dir

22e2b15

check stdarch-gen output via stdarch-gen-common

59674c1

xonx4l force-pushed the port-stdarch-gen branch from a594176 to 59674c1 Compare August 13, 2026 19:31

Kobzol reviewed Aug 14, 2026

View reviewed changes

Comment thread src/bootstrap/src/core/build_steps/test.rs Outdated

Comment thread src/bootstrap/src/core/build_steps/test.rs

Comment thread src/bootstrap/src/core/build_steps/test.rs

Comment thread src/bootstrap/src/core/build_steps/test.rs

add requested changes

9291af1

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 14, 2026

Auto merge of #156674 - xonx4l:port-stdarch-gen, r=<try>

bb3dc02

bootstrap: add bootstrap step to run stdarch-gen checks in CI try-job: x86_64-gnu

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2026

This comment has been minimized.

Sign in to view

xonx4l added 2 commits August 14, 2026 17:16

pin stage0 rustc

8e2b1c4

fix tidy

6cab463

This comment has been minimized.

Sign in to view

pass explicit output dir

f08d8c4

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 15, 2026

Auto merge of #156674 - xonx4l:port-stdarch-gen, r=<try>

397f471

bootstrap: add bootstrap step to run stdarch-gen checks in CI try-job: x86_64-gnu

Kobzol approved these changes Aug 16, 2026

View reviewed changes

add comment

b2e0185

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2026

GuillaumeGomez mentioned this pull request Aug 16, 2026

Rollup of 12 pull requests #161175

Closed

JonathanBrouwer mentioned this pull request Aug 16, 2026

Rollup of 12 pull requests #161179

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2026

Uh oh!

Uh oh!

Conversation

xonx4l commented May 17, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented May 26, 2026

Uh oh!

Kobzol left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Aug 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kobzol commented Aug 14, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 14, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Kobzol commented Aug 15, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 15, 2026

Uh oh!

Kobzol left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kobzol Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 16, 2026

Uh oh!

xonx4l commented Aug 16, 2026

Uh oh!

rust-bors Bot commented Aug 16, 2026

Uh oh!

JonathanBrouwer commented Aug 16, 2026

Uh oh!

rust-bors Bot commented Aug 16, 2026

Uh oh!

Kobzol commented Aug 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xonx4l commented May 17, 2026 •

edited by rustbot

Loading

Kobzol left a comment •

edited by rustbot

Loading

Kobzol left a comment •

edited by rustbot

Loading