resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets by petrochenkov · Pull Request #156284 · rust-lang/rust

petrochenkov · 2026-05-07T16:33:14Z

…lob sets

rustbot · 2026-05-07T16:33:20Z

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 18 candidates

rustbot · 2026-05-07T16:33:21Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- f95f341

petrochenkov · 2026-05-07T16:43:16Z

The proper fix requires landing #149195 first, and may potentially cause some performance issues.

petrochenkov · 2026-05-12T10:24:48Z

r? @mu001999

mu001999 · 2026-05-12T13:05:33Z

@bors r+ rollup

rust-bors · 2026-05-12T13:05:37Z

📌 Commit 235fa6b has been approved by mu001999

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

…uwer Rollup of 6 pull requests Successful merges: - #156287 (move more compiler crates away from `box_patterns` ) - #156428 (Move `std::io::Cursor` to `core::io`) - #156431 (Move `std::io::util` to `core::io`) - #156145 (Move tests cast) - #156284 (resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets) - #156502 (Give an example of a Ctor in the doc-comments)

Rollup merge of #156284 - petrochenkov:kvak2, r=mu001999 resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets Fixes #156264.

Mark-Simulacrum · 2026-05-17T17:13:41Z

@rust-timer build 27617b5

cc #156506 (comment)

rust-timer · 2026-05-17T18:04:10Z

Finished benchmarking commit (27617b5): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-1.0%, -0.8%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

Results (secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 510.527s -> 508.407s (-0.42%)
Artifact size: 400.06 MiB -> 400.06 MiB (-0.00%)

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixes rust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixes rust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixes rust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixes rust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

petrochenkov added 2 commits May 7, 2026 18:56

Add a regression test for issue rust-lang#156264

f95f341

resolve: Fix a false positive "cannot reexport" error for ambiguous g…

235fa6b

…lob sets

rustbot assigned JohnTitor May 7, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2026

petrochenkov mentioned this pull request May 7, 2026

E0365 newly triggers on pub(crate) reexports (cannot be re-exported outside) #156264

Closed

meditationmind mentioned this pull request May 10, 2026

Update invite models serenity-rs/serenity#3552

Merged

rustbot assigned mu001999 and unassigned JohnTitor May 12, 2026

This comment was marked as outdated.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2026

JonathanBrouwer mentioned this pull request May 12, 2026

Rollup of 6 pull requests #156506

Merged

rust-bors Bot merged commit 63322d0 into rust-lang:main May 12, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone May 12, 2026

rust-timer added a commit that referenced this pull request May 12, 2026

Unrolled build for #156284

27617b5

Rollup merge of #156284 - petrochenkov:kvak2, r=mu001999 resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets Fixes #156264.

This comment has been minimized.

Sign in to view

petrochenkov deleted the kvak2 branch June 17, 2026 14:54

This was referenced Jul 9, 2026

Regression 1.96.1 → 1.97.0: "missing optimized MIR" for pub fn glob-reexported alongside a restricted glob duplicate #159038

Open

resolve: fix effective visibilities for items in ambiguous glob sets #159039

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets#156284

resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets#156284
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
petrochenkov:kvak2

petrochenkov commented May 7, 2026

Uh oh!

rustbot commented May 7, 2026

Uh oh!

rustbot commented May 7, 2026

Uh oh!

petrochenkov commented May 7, 2026

Uh oh!

petrochenkov commented May 12, 2026

Uh oh!

This comment was marked as outdated.

mu001999 commented May 12, 2026

Uh oh!

rust-bors Bot commented May 12, 2026

Uh oh!

Uh oh!

Mark-Simulacrum commented May 17, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

petrochenkov commented May 7, 2026

Uh oh!

rustbot commented May 7, 2026

Uh oh!

rustbot commented May 7, 2026

Uh oh!

petrochenkov commented May 7, 2026

Uh oh!

petrochenkov commented May 12, 2026

Uh oh!

This comment was marked as outdated.

mu001999 commented May 12, 2026

Uh oh!

rust-bors Bot commented May 12, 2026

Uh oh!

Uh oh!

Mark-Simulacrum commented May 17, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 17, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants