dirfd file operations (2/4) by Qelxiros · Pull Request #150679 · rust-lang/rust

Qelxiros · 2026-01-04T18:13:00Z

Previous PR: #146341
Reference: #139514
Tracking issue: #120426

rustbot · 2026-01-04T18:13:05Z

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Qelxiros · 2026-01-04T21:31:36Z

This is going to need a try run for windows at least. @tgross35 I'll let you decide which jobs make the most sense here.

tgross35 · 2026-01-04T23:25:01Z

@bors2 try jobs=x86_64-msvc-*

Cc @the8472 for dirfd, and @ChrisDenton for Windows

dirfd file operations (2/4) try-job: x86_64-msvc-*

rust-bors · 2026-01-05T02:06:13Z

☀️ Try build successful (CI)
Build commit: 796e04e (796e04e9c306cfa50aa215b1e93ebdb1cbdc51d8, parent: e29fcf45e4ae686d77b490bf07320f0d3a2cf35f)

tgross35 · 2026-01-24T05:12:47Z

I haven't had a chance to look here yet, sorry

@rustbot reroll

Qelxiros · 2026-04-01T23:05:13Z

@rustbot reroll

Mark-Simulacrum

The Windows code looks like it could use a second set of eyes from someone with Windows knowledge, unless we manage to remove most of the new code through reusing the existing rename logic.

View changes since this review

Mark-Simulacrum · 2026-04-04T13:21:23Z

+        opts.access_mode(c::DELETE);
+        opts.custom_flags(c::FILE_FLAG_OPEN_REPARSE_POINT | c::FILE_FLAG_BACKUP_SEMANTICS);
+        let handle = self.open_file_native(from, &opts, dir)?;
+        // Calculate the layout of the `FILE_RENAME_INFORMATION` we pass to `NtSetInformationFile`


A bunch of the content here looks similar to

rust/library/std/src/sys/fs/windows.rs

Line 1313 in 2972b5e

let err = api::get_last_error();

-- could we reuse some of that? Is there an opportunity to use MoveFileExW for this path at all?

MoveFileExW operates exclusively on filenames. Dir::rename is intended to be TOCTOU-safe, so it needs to use directory Handles. I've factored out the NtSetInformationFile section of both functions into nt_rename. The implementations are a little different from one another, so I'm not 100% sure I got the function signature right. I'll wait for the CI to run and reevaluate.

Mark-Simulacrum · 2026-06-07T13:00:31Z

    }

+    pub fn remove_file(&self, path: &Path) -> io::Result<()> {
+        run_path_with_cstr(path, &|path| self.remove_c(path, false))


Should this check somewhere that the passed path is relative? Otherwise we're not actually getting the promised semantics: "If path is absolute, then dirfd is ignored." (https://www.man7.org/linux/man-pages/man2/unlink.2.html)

View changes since the review

That seems like a question for all dirfd-relative operations that take a path: should they require the path to be relative, or should they allow absolute paths and do the obvious thing for them? IMO it makes sense to allow absolute paths. That basically lets you use dirfd as a "local working directory" without the downsides of set_current_dir.

The argument against is that people would like to use dirfd in security relevant contexts. You can build a less secure variant on top of dirfd but not really the other way around (well technically you can but defaulting to the less secure option has historically been a footgun).

But in any case, I think this is a question for libs-api.

It's unstable, so you can put it on the open questions in the tracking issue? I don't think this needs to be settled immediately.

On linux there's openat2 which adds RESOLVE_BENEATH and RESOLVE_IN_ROOT flags which give you certain security properties, depending on which you want.

The tracking issue explicitly says that this is NOT using O_BENEATH. We also have a fallback implementation that just stores the dir name as a string. So anything security critical seems to be already ruled out.

I have added this to #120426.

rustbot · 2026-06-07T13:05:13Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

RalfJung · 2026-07-11T10:36:41Z

@Qelxiros we haven't heard from you in a while here -- are you still interested in working on this?
If not that's okay, it would just be good for us to know this so someone else can take over. :)

Qelxiros · 2026-07-15T03:48:13Z

I am still interested in working on this; I had changes for the previous review in my local repo, but I forgot to push them.

rustbot · 2026-07-15T03:52:24Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

RalfJung · 2026-07-15T06:34:47Z

Remember to @rustbot ready when this is ready for review again, i.e., after you incorporated all feedback.

Qelxiros · 2026-07-15T12:24:07Z

@rustbot ready

Mark-Simulacrum · 2026-07-16T12:24:20Z

@bors squash msg="add file operations to std dirfd"

rust-bors · 2026-07-16T12:24:44Z

🔨 3 commits were squashed into b6849b3.

Mark-Simulacrum · 2026-07-16T12:39:04Z

@bors r+ rollup=iffy

rust-bors · 2026-07-16T12:39:07Z

📌 Commit b6849b3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…acrum dirfd file operations (2/4) Previous PR: rust-lang#146341 Reference: rust-lang#139514 Tracking issue: rust-lang#120426

…uwer Rollup of 18 pull requests Successful merges: - #150679 (dirfd file operations (2/4)) - #158758 (Rename `lazy_type_alias` feature gate to `checked_type_aliases` ) - #159177 (Explicitly materialize debuginfo tests for all debuggers) - #159392 (Update Rust crate rand to v0.9.3 [SECURITY]) - #159393 (Update Rust crate rkyv to v0.8.16 [SECURITY]) - #159394 (Update Rust crate tar to v0.4.46 [SECURITY]) - #159395 (Update Rust crate tracing-subscriber [SECURITY]) - #159193 (Port compiletest's CLI to clap) - #158992 (Shorten types more when only interesting part is lifetimes) - #159226 (Track extra_lifetime_params_map per-owner) - #159273 (tidy: document u64 limit for numeric sort keys) - #159322 (Fix safety doc in intrinsics::simd) - #159329 (Fix the stale metrics directory warning) - #159357 (Add regression tests for two fixed issues) - #159360 (Remove FIXMEs referencing #44232) - #159375 (make a couple codegen-llvm tests compatible with 2021 edition) - #159381 (emit `(lldb)` prefix to make commands more distinct) - #159396 (Update actions/checkout action to v7)

rustbot assigned tgross35 Jan 4, 2026

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added a commit that referenced this pull request Jan 4, 2026

Auto merge of #150679 - Qelxiros:dirfd-files, r=<try>

796e04e

dirfd file operations (2/4) try-job: x86_64-msvc-*

This comment has been minimized.

Sign in to view

rustbot assigned ChrisDenton and unassigned tgross35 Jan 24, 2026

Qelxiros force-pushed the dirfd-files branch from 003285e to 2884bd4 Compare January 24, 2026 18:52

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-files branch from 2884bd4 to 8adc293 Compare March 30, 2026 17:15

This comment has been minimized.

Sign in to view

Qelxiros mentioned this pull request Mar 30, 2026

reference dirfd implementation #139514

Draft

rustbot assigned Mark-Simulacrum and unassigned ChrisDenton Apr 1, 2026

Mark-Simulacrum reviewed Apr 4, 2026

View reviewed changes

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2026

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-files branch from 2c61d00 to f7f9f42 Compare April 30, 2026 17:18

rustbot added the O-windows Operating system: Windows label Apr 30, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2026

Mark-Simulacrum requested changes Jun 7, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2026

RalfJung reviewed Jul 11, 2026

View reviewed changes

Comment thread library/std/src/fs/tests.rs Outdated

RalfJung mentioned this pull request Jul 14, 2026

feat: add required syscalls for remove_dir_all rust-lang/miri#5057

Open

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-files branch from db42a91 to 18ed9ea Compare July 15, 2026 03:52

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2026

This comment has been minimized.

Sign in to view

add file operations to std dirfd

b6849b3

rust-bors Bot force-pushed the dirfd-files branch from 18ed9ea to b6849b3 Compare July 16, 2026 12:24

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2026

This was referenced Jul 16, 2026

Rollup of 18 pull requests #159397

Closed

Rollup of 18 pull requests #159407

Merged

rust-bors Bot merged commit 9133612 into rust-lang:main Jul 16, 2026
13 checks passed

Uh oh!

Uh oh!

Conversation

Qelxiros commented Jan 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

Qelxiros commented Jan 4, 2026

Uh oh!

tgross35 commented Jan 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jan 5, 2026

Uh oh!

This comment has been minimized.

tgross35 commented Jan 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Qelxiros commented Apr 1, 2026

Uh oh!

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Qelxiros Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

Mark-Simulacrum Jun 7, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJung Jun 7, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisDenton Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

the8472 Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

RalfJung Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jun 7, 2026

Uh oh!

Uh oh!

RalfJung commented Jul 11, 2026

Uh oh!

This comment has been minimized.

Qelxiros commented Jul 15, 2026

Uh oh!

rustbot commented Jul 15, 2026

Uh oh!

RalfJung commented Jul 15, 2026

Uh oh!

Qelxiros commented Jul 15, 2026

Uh oh!

Mark-Simulacrum commented Jul 16, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 16, 2026

Uh oh!

Mark-Simulacrum commented Jul 16, 2026

Uh oh!

rust-bors Bot commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Qelxiros commented Jan 4, 2026 •

edited by rustbot

Loading

Mark-Simulacrum left a comment •

edited by rustbot

Loading

Mark-Simulacrum Jun 7, 2026 •

edited by rustbot

Loading

RalfJung Jun 10, 2026 •

edited

Loading